1751915 - WebGLRenderingContext.texImage2D and .texSubImage2D do not accept OffscreenCanvas as a source

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We have set of texImage2D and texSubImage2D variants here, and OffscreenCanvas is missing from the list:

https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/dom/webidl/WebGLRenderingContext.webidl#744

In the WebGL conformance suite, we may use OffscreenCanvas as the canvas type if it is available:

https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/dom/canvas/test/webgl-conf/checkout/js/tests/tex-image-and-sub-image-2d-with-canvas.js#403

And we attempt to use it with texImage2D and texSubImage2D:

https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/dom/canvas/test/webgl-conf/checkout/js/tests/tex-image-and-sub-image-2d-with-canvas.js#265
https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/dom/canvas/test/webgl-conf/checkout/js/tests/tex-image-and-sub-image-2d-with-canvas.js#263

This is likely causing some/all of the WebGL conformance suite test failures, including dom/canvas/test/webgl-conf/checkout/conformance/extensions/oes-texture-float-with-canvas.html.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Note this also applies to WebGL2RenderingContext's variants as well.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

We can confirm Chrome is shipping this as the TexImageSource accepts an OffscreenCanvas object:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/interfaces/webgl1.idl;l=89

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1751915 - Ensure WebGLRenderingContext texImage/etc support OffscreenCanvas as a source.

This patch adds OffscreenCanvas as a texture source for texImage2D,
texSubImage2D and texSubImage2D. This applies to both
WebGLRenderingContext and WebGL2RenderingContext. This was causing
several test failures in the WebGL conformance suite with
OffscreenCanvas.

Depends on D136836

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/820859114930
Ensure WebGLRenderingContext texImage/etc support OffscreenCanvas as a source. r=jgilbert,webidl,smaug

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/820859114930