1751963 - Apply audio settings before starting the audio processing

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Description

[C.M.Chang[:chunmin]]

Per bug 1749281 comment 4, we should apply audio settings before starting the audio processing, since we will need those setting values in the audio processing steps.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1751963 - Rephrase comments for mCurrentPrefs

MediaEngineWebRTCMicrophoneSource doesn't need to know APM. The
AudioInputProcessing takes care of the audio processing provided by
libwebrtc.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1751963 - Set channel-count before pass-through

In the current design, the SetPassThrough can start the initial step
for audio-processing, which requires to know the channel-count requested
by the users, so it's better to set the channel-count before setting the
pass-through to prevent from using an incorrect channel-count value.

Depends on D136919

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1751963 - Remove outdated comments

The NotifyInputData has been removed in bug 1741959. Now the
mRequestedInputChannelCount is totally unrelated with it.

Depends on D136920

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1751963 - Apply audio settings before starting audio

The audio processing configurations should be set before starting audio
device and audio processing.

Depends on D136921

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ae72fb964a8
Rephrase comments for mCurrentPrefs r=padenot
https://hg.mozilla.org/integration/autoland/rev/3ef229753309
Set channel-count before pass-through r=padenot
https://hg.mozilla.org/integration/autoland/rev/d9efbefc2e70
Remove outdated comments r=padenot
https://hg.mozilla.org/integration/autoland/rev/5e58123c1024
Apply audio settings before starting audio r=padenot

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ae72fb964a8
https://hg.mozilla.org/mozilla-central/rev/3ef229753309
https://hg.mozilla.org/mozilla-central/rev/d9efbefc2e70
https://hg.mozilla.org/mozilla-central/rev/5e58123c1024