1752023 - [wpt-sync] Sync PR 32481 - URLPattern: Fix erroneous prefix check in GeneratePatternString().

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32481 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32481
Details from upstream follow.

Ben Kelly <[e-mail]> wrote:

URLPattern: Fix erroneous prefix check in GeneratePatternString().

This fixes another issue related to:

https://github.com/WICG/urlpattern/issues/145

In this case we were incorrectly looking at the prefix value when trying
to determine if we should protect against characters following a :foo
named group. We don't need the prefix check because we already have the
needs_grouping check. With this check in place we would incorrectly
allow following characters when there is an implicit prefix, like / in
a pathname.

Bug: 1289115
Change-Id: Id8a88b55a31c3a0e72310574fe4d7a6fc7781d68
Reviewed-on: https://chromium-review.googlesource.com/3405148
WPT-Export-Revision: 21122794d4e03a8cef5a917c5bfb0a1b5a8cfb65

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 32481 applied with additional changes from upstream: 4928cc8d516868267da4be9a5b9a5f7856dd0b65, fd132aec57c531fdbb71cc7cd18aed97a8e3492a, b717651264109d1ac96e922431b7b846ba8d599f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4df7514f737feb2a045c13626bb8bd7efe7debf4

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/31de176760f6