1752059 - RNP build maintenance

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

• Enable clock_gettime() in Botan for macOS
  • https://searchfox.org/comm-central/rev/746643c2bdd9e6123921aa1cf95dadd6cd69916a/third_party/botan/botan.mozbuild#59
  • macOS builds with 10.12 SDK now
• Stop defining MZLA_RNP_CC/CXX and just use CC/CXX
• Ignore compiler warning when building bzip2
  • unreachable return is expected
  • WARNING - /builds/worker/checkouts/gecko/comm/third_party/bzip2/bzlib.c:1216:11: warning: 'return' will never be executed [-Wunreachable-code-return]
  • INFO - return 0; /*not reached*/

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1752059 - Enable clock_gettime use in macOS builds. r=kaie

As noted in the comment, clock_gettime is part of the macOS SDK starting with
10.12. Minimum required SDK is 10.12.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1752059 - Stop using MZLA_RNP_CC/CXX. r=kaie

The effect is that C++ code will use -std-c++17.

Depends on D136984

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1752059 - Ignore unreachable-code-return error in bzip. r=kaie

Occurs at bzlib.c:1216. As noted in the file, that unreachable return is
expected.

Depends on D136985

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/855b1d909ae5
Enable clock_gettime use in macOS builds. r=kaie
https://hg.mozilla.org/comm-central/rev/e04ffb6d3912
Stop using MZLA_RNP_CC/CXX. r=kaie
https://hg.mozilla.org/comm-central/rev/12d5244ca5b9
Ignore unreachable-code-return error in bzip. r=kaie

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9260772 [details]
Bug 1752059 - Enable clock_gettime use in macOS builds. r=kaie

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: none
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): just build rules for bug 1750969

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9260774 [details]
Bug 1752059 - Ignore unreachable-code-return error in bzip. r=kaie

[Triage Comment]
Approved for esr91

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9260772 [details]
Bug 1752059 - Enable clock_gettime use in macOS builds. r=kaie

[Triage Comment]
Approved for esr91

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9260773 [details]
Bug 1752059 - Stop using MZLA_RNP_CC/CXX. r=kaie

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/3e46daa611f4
https://hg.mozilla.org/releases/comm-esr91/rev/07cca537fcbc
https://hg.mozilla.org/releases/comm-esr91/rev/168048c02b69