1752111 - Make l10n bumper run on autoland instead of mozilla-central

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The cron task which [updates the revisions of the localizations for use in Firefox(https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=fed4cdeef415d8af09a2b212a80b92dfa086c986) got added in bug 1748581. It runs ~3 hours before the Nightly starts.

The execution on mozilla-central has some disadvantages:

• Once pushed, mozilla-central tip is missing builds which have to be built anyway for e.g. artifact builds on Try.
• This requires a merge back to autoland to get the changeset into it.
• If it's not possible to merge changes from autoland to central after it ran and before the next Nightly starts, it will start to schedule all builds and tests which belong to the release graph (which also slows down the delivery of the next Nightly build).

Advantage:

• Localization changesets are often newer than a workflow which lands the L10n changes on autoland (because often 3h won't be sufficient to get the changes merged to mozilla-central).

Comment 1

[Aki Sasaki (not active)]

We can do this, but we'll have to account for autoland being closed (I'm under the impression that autoland is closed a significantly higher percentage of the time than central?). We could allow for manual triggering of the hook once we reopen, maybe.

(Also I'm guessing we'll hit race conditions more often when landing to autoland, since Lando is landing things all the time.)

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central is in approval-required state in general, autoland can be closed but if you submit the patch with moz-phab and trigger the landing, this would get landed after the tree reopens. Letting the sheriffs land it is another option.

Comment 3

[Aki Sasaki (not active)]

Treescript doesn't have phab abilities yet; it pushes directly to central. I believe the task will upload a diff on failure or success, so that diff is landable.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Aki Sasaki [:aki] (he/him) (UTC-6) from comment #1)

We can do this, but we'll have to account for autoland being closed (I'm under the impression that autoland is closed a significantly higher percentage of the time than central?). We could allow for manual triggering of the hook once we reopen, maybe.

Can we just land these DONTBUILD CLOSED TREE? These don't seem like the kind of thing that's going to cause any disruption to sheriffs if they land on a closed autoland tree. I'm coming back to this bug because in general it's causing a lot of noise on mozilla-central to have these directly pushing there (for example, extra bisection steps with mozregression) and it would be nice if we get these pushing to autoland instead to reduce the number of merges that need to be done.

Also, yes, we should definitely allow these hooks to be manually triggered (in general, I'm in favor of all cron-triggered hooks being available for manual activation as the default).

(Also I'm guessing we'll hit race conditions more often when landing to autoland, since Lando is landing things all the time.)

Yeah, we'd certainly need to be able to handle racing.

Comment 5

[Aki Sasaki (not active)]

Sure. We need to do some l10n automation cross-training this half anyway; we can add this to the list of things I can mentor someone on.

Comment 6

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1752111 - Make l10n bumper run on autoland instead of mozilla-central r=aki

Comment 7

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1752111 - Update ci-configuration to run the l10n-bumper on autoland instead of mozilla-central r=aki

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/ci-configuration/rev/ba5e3180c580
Update ci-configuration to run the l10n-bumper on autoland instead of mozilla-central r=aki

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e2145b5a21
Make l10n bumper run on autoland instead of mozilla-central r=aki

Comment 10

[Iulian Moraru]

Backed out for causing linting failures on release_version_bump.py.

Push with failures

Failure log for black
Failure log for f8

Backout link

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f4763a4887
Make l10n bumper run on autoland instead of mozilla-central r=aki

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing l10n-bump failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0227377af4cb054972ad16c05e8f696a8d67de8

Push with failure

Failure log

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9ce1bc0acf15
Backed out changeset b3f4763a4887 for causing l10n-bump failures.

Comment 14

[Gabriel Bustamante [:gabriel]]

Attachment: Bug 1752111 - Grant the autoland project permissions to create gecko-3-tree tasks r=aki

Comment 15

[Gabriel Bustamante [:gabriel]]

Attachment: Allow autoland branch to use treescript push - scriptworker #552

Comment 16

[Gabriel Bustamante [:gabriel]]

Comment on attachment 9289971 [details] [diff] [review]
Allow autoland branch to use treescript push - scriptworker #552

https://github.com/mozilla-releng/scriptworker/pull/552

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/ci-configuration/rev/a00cebf1e929
Grant the autoland project permissions to create gecko-3-tree tasks r=aki

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9befcc1f72b
Make l10n bumper run on autoland instead of mozilla-central r=aki

Comment 19

[Sandor Molnar[:smolnar]]

Backed out changeset a9befcc1f72b (bug 1752111) for causint l10n bumper bustages on autoland.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f1731a6d1414bcb1d6cabeca3d901e22db4e53b8

Push with failures

Failure log

Comment 20

[Aki Sasaki (not active)]

Connor, does the ffxbld user have access to land changes on autoland? Trying to figure out why we're getting remote: abort: could not lock working directory of /repo/hg/mozilla/integration/autoland: Permission denied when pushing there.

Comment 21

[Connor Sheehan [:sheehan]]

Autoland uses a special scm_autoland permission. I ran groups ffxbld on the hgssh push server and it appears the bot does not have that permission (this works because LDAP permissions are mirrored into Unix groups on that server).

Comment 22

[Aki Sasaki (not active)]

(In reply to Connor Sheehan [:sheehan] from comment #21)

Autoland uses a special scm_autoland permission. I ran groups ffxbld on the hgssh push server and it appears the bot does not have that permission (this works because LDAP permissions are mirrored into Unix groups on that server).

Thank you!

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22e8ad4a5632
Make l10n bumper run on autoland instead of mozilla-central r=aki

Comment 24

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/22e8ad4a5632

Comment 25

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/22e8ad4a5632