1752171 - Remove unused lock in CompositorBridgeChild

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

CompositorBridgeChild has this comment:
// Off-Main-Thread Painting state. This covers access to the OMTP-related
// state below.
Monitor mPaintLock;

Below are some fields I'm removing (unused) in bug 1752168, mCanvasChild, and mWebGPUChild. Are those *Child members accessed on multiple threads, and do they need to obtain the mPaintLock? (I'm guessing no).

Conversely, the one place mPaintLock is still taken is in ActorDestroy(), to guard mCanSend and mActorDestroyed. Great (though it's not at all obvious those would be protected from the .h file), except......

None of the other accesses to mCanSend/mActorDestroyed are locked.

Do they need to be locked (are they accessed from multiple threads)? If not, can we just get rid of the mutex?

Comment 1

[Nicolas Silva [:nical]]

The lock can go away entirely. It was introduced to do some painting off the main thread but OMTP has since been removed.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Doesn't need to be a sec bug anymore

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1752171: Remove unused lock from CompositorBridgeChild r=#gfx-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/6c5bbb5691ff
Remove unused lock from CompositorBridgeChild r=gfx-reviewers,jrmuizel

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6c5bbb5691ff