Build with DOM ReadableStreams by default.
Categories
(Core :: DOM: Streams, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
References
(Regressed 1 open bug)
Details
Attachments
(3 files)
This is the bug where the actual change in implementation for streams will be landed.
Assignee | ||
Comment 1•4 months ago
|
||
Updated•4 months ago
|
Assignee | ||
Comment 2•4 months ago
|
||
Depends on D137770
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6cc91b823c3 Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug https://hg.mozilla.org/integration/autoland/rev/455cd9209987 Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander
Comment 4•4 months ago
|
||
Backed out for causing build bustages on ReadableByteStreamController.cpp
Failure line(s): /builds/worker/checkouts/gecko/dom/streams/ReadableByteStreamController.cpp:1940:40: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
Assignee | ||
Updated•4 months ago
|
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e53660b82b9a Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug https://hg.mozilla.org/integration/autoland/rev/bf7e7a03d4bb Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander
Assignee | ||
Updated•4 months ago
|
Comment 6•4 months ago
|
||
Backed out for causing failures on testReadableStream.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/9e1168be3b809006570b0f4964482cc27d1d95c0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=367088884&repo=autoland
Failure message : TEST-UNEXPECTED-FAIL | testReadableStream_ReadableStreamDefaultReaderRead_CrossCompartment | /builds/worker/checkouts/gecko/js/src/jsapi-tests/testReadableStream.cpp:1169:CHECK failed: stream -- TypeError: ReadableStream is disabled
Assignee | ||
Updated•4 months ago
|
Comment 7•4 months ago
|
||
Please also check this hazard bustage: https://treeherder.mozilla.org/logviewer?job_id=367109737&repo=autoland&lineNumber=102341
Assignee | ||
Comment 8•4 months ago
|
||
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c89f3f10d0e Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug https://hg.mozilla.org/integration/autoland/rev/bc0d7fc3a472 Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander
Comment 10•4 months ago
|
||
Backed out for causing Bp-hybrid bustages on WritableStream.cpp
Failure log: https://treeherder.mozilla.org/logviewer?job_id=367433471&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/db496a69c2292ff760eadec6d7649aad10bee47e
Assignee | ||
Comment 11•4 months ago
|
||
Comment 12•4 months ago
|
||
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d706676f161 Add missing RootedDictionary include to make non-unified build work r=evilpie https://hg.mozilla.org/integration/autoland/rev/02480e689136 Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug https://hg.mozilla.org/integration/autoland/rev/f57513280ac3 Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander
Assignee | ||
Updated•4 months ago
|
Comment 13•4 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d706676f161
https://hg.mozilla.org/mozilla-central/rev/02480e689136
https://hg.mozilla.org/mozilla-central/rev/f57513280ac3
Comment 14•3 months ago
•
|
||
Hi Matthew, Can you please help me understand the documentation impact of this change, if any?
Looking at ReadableStream we already support that, so my guess is that we've changed the way that it is supported "under the hood". If so, my assumption is probably this is an invisible update for developers. Correct?
PS Further, Remove JS Streams implementation of Writable Stream and PipeTo (bug1755391 ) is the same kind of thing right - replacement of some underlying API with another?
Assignee | ||
Comment 15•2 months ago
|
||
Hey Hamish: This change is indeed invisible to developers. Ditto the bug you flagged (we have never shipped WritableStreams on the web)
That should be changing soon though.
Comment 16•2 months ago
|
||
Thanks Matthew - appreciate the prompt response. I've removed the dev-doc-needed.
Description
•