1752206 - Build with DOM ReadableStreams by default.

Status: RESOLVED FIXED

(Core :: DOM: Streams, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

This is the bug where the actual change in implementation for streams will be landed.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

Attachment: Bug 1752206 - Flip the sense of the DOM Streams CI (test JS streams there instead now) r?smaug

Comment 2

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

Attachment: Bug 1752206 - Enable DOM Streams by default r?smaug

Depends on D137770

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6cc91b823c3
Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug
https://hg.mozilla.org/integration/autoland/rev/455cd9209987
Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on ReadableByteStreamController.cpp

Backout link

Push with failures

Failure log

Failure line(s): /builds/worker/checkouts/gecko/dom/streams/ReadableByteStreamController.cpp:1940:40: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e53660b82b9a
Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug
https://hg.mozilla.org/integration/autoland/rev/bf7e7a03d4bb
Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on testReadableStream.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e1168be3b809006570b0f4964482cc27d1d95c0

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&duplicate_jobs=visible&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=bf7e7a03d4bb24f0ddc4d436a1874bfa202e943b&selectedTaskRun=T74-Or1LRDiUwHCsRXljFw.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=367088884&repo=autoland

Failure message : TEST-UNEXPECTED-FAIL | testReadableStream_ReadableStreamDefaultReaderRead_CrossCompartment | /builds/worker/checkouts/gecko/js/src/jsapi-tests/testReadableStream.cpp:1169:CHECK failed: stream -- TypeError: ReadableStream is disabled

Comment 7

[Narcis Beleuzu [:NarcisB]]

Please also check this hazard bustage: https://treeherder.mozilla.org/logviewer?job_id=367109737&repo=autoland&lineNumber=102341

Comment 8

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

On it

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c89f3f10d0e
Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug
https://hg.mozilla.org/integration/autoland/rev/bc0d7fc3a472
Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing Bp-hybrid bustages on WritableStream.cpp

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=aULdd-4MRhGHGn7QNe5gGQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=bc0d7fc3a4729dbd763b5fcaa88ea8bfba3cef4d&tochange=db496a69c2292ff760eadec6d7649aad10bee47e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=367433471&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/db496a69c2292ff760eadec6d7649aad10bee47e

Comment 11

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

Attachment: Bug 1752206 - Add missing RootedDictionary include to make non-unified build work r?evilpie

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d706676f161
Add missing RootedDictionary include to make non-unified build work r=evilpie
https://hg.mozilla.org/integration/autoland/rev/02480e689136
Flip the sense of the DOM Streams CI (test JS streams there instead now) r=smaug
https://hg.mozilla.org/integration/autoland/rev/f57513280ac3
Enable DOM Streams by default r=smaug,firefox-build-system-reviewers,nalexander

Comment 13

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/4d706676f161
https://hg.mozilla.org/mozilla-central/rev/02480e689136
https://hg.mozilla.org/mozilla-central/rev/f57513280ac3

Comment 14

[Hamish Willee]

Hi Matthew, Can you please help me understand the documentation impact of this change, if any?

Looking at ReadableStream we already support that, so my guess is that we've changed the way that it is supported "under the hood". If so, my assumption is probably this is an invisible update for developers. Correct?

PS Further, Remove JS Streams implementation of Writable Stream and PipeTo (bug1755391 ) is the same kind of thing right - replacement of some underlying API with another?

Comment 15

[Matthew Gaudet (he/him) [:mgaudet] | Out Until January 3, 2023]

Hey Hamish: This change is indeed invisible to developers. Ditto the bug you flagged (we have never shipped WritableStreams on the web)

That should be changing soon though.

Comment 16

[Hamish Willee]

Thanks Matthew - appreciate the prompt response. I've removed the dev-doc-needed.