LSNG: Empty values can't be persisted
Categories
(Core :: Storage: localStorage & sessionStorage, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox96 | --- | unaffected |
| firefox97 | + | fixed |
| firefox98 | + | fixed |
People
(Reporter: janv, Assigned: jjalkanen)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
|
||
Comment 1•2 years ago
|
||
[Tracking Requested - why for this release]: Easy to trip over regression from bug 1681300.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25673139c9d8 Prevent conversion of empty values to nulls on bind. r=dom-storage-reviewers,janv
|
|
Assignee | |
Comment 4•2 years ago
|
||
Comment on attachment 9261028 [details]
Bug 1752265 - Prevent conversion of empty values to nulls on bind. r=#dom-storage-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Inserting empty values in local storage will fail in all builds and the nightly build will crash due to debug asserts.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch handles empty values as a special case, otherwise nothing changes.
- String changes made/needed: None
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
|
||
Comment 6•2 years ago
|
||
Comment on attachment 9261028 [details]
Bug 1752265 - Prevent conversion of empty values to nulls on bind. r=#dom-storage-reviewers
Fixes an easily-hit LS regression introduced in Fx97. Approved for 97.0rc1. Thanks for including a test.
|
|
||
Comment 7•2 years ago
|
||
| bugherder uplift | ||
|
|
Assignee | |
Comment 8•2 years ago
|
||
Sqlite ALTER TABLE statement documentation makes recommendations under
section about making other kinds of table schema changes.
|
|
||
Comment 9•2 years ago
|
||
Comment on attachment 9262634 [details]
Bug 1752265 - Perform schema change using recommended steps. r=#dom-storage-reviewers
Revision D138006 was moved to bug 1748260. Setting attachment 9262634 [details] to obsolete.
Description
•