1752402 - Move VPNSubStatus to BrowserUtils and use in shouldShowVPNPromo and maybe expose as targeting criterion

Status: NEW

(Firefox :: Messaging System, enhancement, P3)

Description

[Meg Viar [:mviar]]

Follow up to bug 1747149

• Move VPNSubStatus (found here) to BrowserUtils and rename shouldShowVPN.

The following can be moved to a separate, follow-up bug if needed:

• Expose shouldShowVPN as a targeting criterion for ASRouter. Currently, we're just looking for connected OAuth tokens using attachedFxAOAuthClients (found here).
• Update shouldShowVPN logic to default to showing the VPN if there's an OAUTH token, but the subscription can't be verified.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

https://searchfox.org/mozilla-central/search?q=VPNSubStatus&path=&case=false&regexp=false link to current VPNSubStatus code & references.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Note that code shouldShowVPNPromo currently does not attempt to check subscription status for VPN, and is currently used in (at least) the More from Mozilla prefs pane, so if we do something like what is proposed in this bug, it would change the behavior for MfM and any other current users, unless we specifically designed a way to opt-out of that check.