1752634 - [wpt-sync] Sync PR 32603 - Add <dimension-token> type-checking to CSSNumericValue::parse()

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32603 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32603
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Add <dimension-token> type-checking to CSSNumericValue::parse()

This patch implements a recent spec bug fix:

https://github.com/w3c/css-houdini-drafts/pull/1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/3425673
WPT-Export-Revision: 12b08bfb756f754967af75f73bc6789ad4be7569

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b92098f36fda40629f10d6db90f688661550fe5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 8
FAIL: 1

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-2004-qr-debug] (Chrome: OK, Safari: OK)
Parsing an invalid string throws SyntaxError: FAIL (Chrome: PASS, Safari: FAIL)
Parsing a string with a non numeric token throws SyntaxError: FAIL (Chrome: PASS, Safari: FAIL)
Parsing a string with left over numeric tokens throws SyntaxError: FAIL (Chrome: PASS, Safari: FAIL)
Parsing a calc with incompatible units throws a SyntaxError: FAIL (Chrome: PASS, Safari: FAIL)
Parsing a <dimension-token> with invalid units throws a SyntaxError: FAIL (Chrome: FAIL, Safari: FAIL)
Parsing ignores surrounding spaces: FAIL (Chrome: PASS, Safari: FAIL)
Parsing min() is successful: FAIL (Chrome: PASS, Safari: FAIL)
Parsing max() is successful: FAIL (Chrome: PASS, Safari: FAIL)
Parsing clamp() is successful: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/stylevalue-subclasses/numeric-objects/parse.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-2004-qr-debug] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/711d18f4c75e
[wpt PR 32603] - Add <dimension-token> type-checking to CSSNumericValue::parse(), a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ddc93efd327
[wpt PR 32603] - Add <dimension-token> type-checking to CSSNumericValue::parse(), a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7ddc93efd327