1752695 - Reject pending reads when releasing reader

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Description

[Tom S [:evilpie]]

This implements the changes from https://github.com/whatwg/streams/pull/1168. This is a pretty broad change and browsing the diff is complicated, so I hope I got everything. https://whatpr.org/streams/1168/7f7d68b...e9e78fe.html can help a little bit.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1752695 - Reject pending reads when releasing reader. r?mgaudet

This implements the changes from https://github.com/whatwg/streams/pull/1168.

Comment 2

[dakkeraton]

I'm not sure this wouldn't run afoul of something that's handling labels. Reject pending reads when releasing reader?
http://www.dakkeratonabadi.com/

Comment 4

[Tom S [:evilpie]]

I don't want to land this change without the WPT update, because otherwise we introduce new failures (that we would have to ignore) and one whole test file errors. Sadly that update seems to drag on.

Comment 5

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/autoland/rev/37c47a72c9e2064a0b8c7aa38ed1ae42b85f4e0c

I accidentally landed this as DONTBUILD, but I at least triggered the domstreams CI test manually.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/37c47a72c9e2