1752736 - Opening about:support with an URL fragment does not scroll to selected section

Status: VERIFIED FIXED

(Toolkit :: General, defect, P5)

Description

[Piotr Henryk Dabrowski]

Steps to reproduce:

Open "about:support" with an URL fragment, like:
about:support#place-database

Actual results:

"about:support" page is scrolled to top, and does not scroll to selected section (h2 tag).
You need to focus address bar (F6) and confirm the URL again (Return) for it to scroll to the given section.

Expected results:

"about:support" with an URL fragment should be opened already scrolled to selected section.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

I expect it's a result of the page being populated asynchronously after the load event. It'd have to be populated sooner, and even then the async-ness might mean it won't work (or be unreliable). Alternatively, we'd have to manually check for the hash on pageload in aboutSupport.js and force the scroll that way.

Comment 3

[Alex Cornestean]

Hello,

I reproduced the issue as per the mentioned STR on the latest Nightly (98.0a1/20220131212843), Beta (97.0/20220131171509) and Release (96.0.3/20220126154723) under Windows 10 x64 and Ubuntu 16.04 LTS.

Pasting “about:support#place-database” in the address bar and hitting Return will open the about:support page scrolled at the top and not at he selected section, as described in the report.

After the above, focusing the address bar and hitting Return again will indeed scroll to the given section.

Comment 4

[gliu20]

Hey there! I'd be happy to upload a fix for this.

Alternatively, we'd have to manually check for the hash on pageload in aboutSupport.js and force the scroll that way.
It seems like your assumption is correct. I did some testing with some code that forces a scroll on page load, and that seemed to resolve the issue.

If this is something we're planning on implementing, I can send over a patch for review.

Comment 5

[:Gijs (he/him)]

(In reply to gliu20 from comment #4)

Hey there! I'd be happy to upload a fix for this.

Alternatively, we'd have to manually check for the hash on pageload in aboutSupport.js and force the scroll that way.
It seems like your assumption is correct. I did some testing with some code that forces a scroll on page load, and that seemed to resolve the issue.

If this is something we're planning on implementing, I can send over a patch for review.

Sure, I would be happy to take a patch for this.

Comment 6

[gliu20]

Attachment: Bug 1752736 - Scroll to hash on pageload in about:support. r?Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13e44c376f15
Scroll to hash on pageload in about:support. r=Gijs

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/13e44c376f15

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 10

[Alex Cornestean]

Verified the fix on the latest Nightly (100.0a1/20220322214632) under Windows 10 x64 and Ubuntu 16.04 LTS.

Following the original STR, pasting “about:support#place-database” in the address bar and hitting Return will now open the about:support page scrolled at the correct section (Places Database), confirming the fix.