Closed Bug 1752833 Opened 8 months ago Closed 7 months ago

Remove MENUBAR_CAN_AUTOHIDE use from browser.css

Categories

(Firefox :: General, task)

Desktop
All
task
Points:
2

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: Gijs, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting] )

Attachments

(1 file)

There's already an ifdef for this in the markup: https://searchfox.org/mozilla-central/rev/78963fe42f8d5f582f84da84a5e78377b6c1fc32/browser/base/content/navigator-toolbox.inc.xhtml#19-23 .

The autohide attribute is added/removed when the toolbar is made permanently visible by using the toolbox context menu to that effect.

The 4 selectors (in 3 blocks) that are behind this condition in browser.css are all using autohide=true or :not([autohide=true]). The former can already never be true on OSes where we can't autohide the menubar; the latter of course can. The simplest way to make that rule not apply when it currently doesn't (ie on macOS) is probably to just add a canautohide attribute on the toolbar inside the #ifdef in the markup linked in the first paragraph, and then to add that to the selector.

Points: --- → 2
Assignee: nobody → sclements
Attachment #9266550 - Attachment description: WIP: Bug 1752833 - remove menubar_can_autohide from browser.css → Bug 1752833 - remove menubar_can_autohide from browser.css r=sfoster
Status: NEW → ASSIGNED
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee9b7007dd66
remove menubar_can_autohide from browser.css r=sfoster
Flags: needinfo?(sclements)
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09e2cd4dad91
remove menubar_can_autohide from browser.css r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Regressions: 1775290
No longer regressions: 1775290
You need to log in before you can comment on or make changes to this bug.