1752833 - Remove MENUBAR_CAN_AUTOHIDE use from browser.css

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[:Gijs (he/him)]

There's already an ifdef for this in the markup: https://searchfox.org/mozilla-central/rev/78963fe42f8d5f582f84da84a5e78377b6c1fc32/browser/base/content/navigator-toolbox.inc.xhtml#19-23 .

The autohide attribute is added/removed when the toolbar is made permanently visible by using the toolbox context menu to that effect.

The 4 selectors (in 3 blocks) that are behind this condition in browser.css are all using autohide=true or :not([autohide=true]). The former can already never be true on OSes where we can't autohide the menubar; the latter of course can. The simplest way to make that rule not apply when it currently doesn't (ie on macOS) is probably to just add a canautohide attribute on the toolbar inside the #ifdef in the markup linked in the first paragraph, and then to add that to the selector.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1752833 - remove menubar_can_autohide from browser.css r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee9b7007dd66
remove menubar_can_autohide from browser.css r=sfoster

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset ee9b7007dd66 (Bug 1752833) for causing bc failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=PJX6pvpnSdK6ZLxDEUFIQA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ee9b7007dd66e70cf8ae9b6ab7e48fa8a80dee2b&searchStr=bc

Log: https://treeherder.mozilla.org/logviewer?job_id=370963670&repo=autoland&lineNumber=35364
https://treeherder.mozilla.org/logviewer?job_id=370963129&repo=autoland&lineNumber=7314
https://treeherder.mozilla.org/logviewer?job_id=370962031&repo=autoland&lineNumber=4830
https://treeherder.mozilla.org/logviewer?job_id=370962296&repo=autoland&lineNumber=23386

Backout: https://hg.mozilla.org/integration/autoland/rev/70d91c58d788d995110dd126760c0628fbfa934c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e2cd4dad91
remove menubar_can_autohide from browser.css r=sfoster

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/09e2cd4dad91