1752879 - Bootstrap on macOS unexpectedly requires `/usr/local/Homebrew/bin` in PATH, failing build

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

When I run mach bootstrap (GeckoView full build), I get the following error:

Your environment's PATH variable lists a system path directory (/usr/bin)
before the path to your package manager's binaries (/usr/local/Homebrew/bin).
This means that the package manager's binaries likely won't be
detected properly.

Modify your shell's configuration (e.g. ~/.profile or
~/.bash_profile) to have /usr/local/Homebrew/bin appear in $PATH before /usr/bin. e.g.

    export PATH=/usr/local/Homebrew/bin:$PATH

Once this is done, start a new shell (likely Command+T) and run
this bootstrap again.

However, /usr/local/Homebrew/bin just contains the brew binary and none of the packages. I think we want to compare against /usr/local/bin/, which is where Homebrew installs all the packages (on Intel macs). I think the change in behavior is from this change in bug 1744884 on the 21st (set as blocking this bug since it's a regression).

On element...

• Shusta mentioned M1 macs install to /opt/homebrew/bin so we should use brew --prefix to identify the path rather than hardcoding it.
• glandium mentioned we don't rely on brew much anymore so they'd remove the check entirely

A workaround is to comment out the check, specifically these lines.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1744884

Comment 2

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1752879 - Remove unnecessary check for Homebrew PATH ordering r?#build

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5d0988077bb
Remove unnecessary check for Homebrew PATH ordering r=firefox-build-system-reviewers,glandium

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e5d0988077bb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7471e91f8bdf