Closed Bug 1752925 Opened 2 years ago Closed 2 years ago

We fire an onNewScript notification for each time we run the eval code for log points / conditional breakpoints

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: alexical, Assigned: alexical)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This takes up the majority of the time in the content process when a log point is added to a hot loop: https://share.firefox.dev/3KWCsYt

Assignee: nobody → dothayer
Status: NEW → ASSIGNED

Profiles of code executing with conditional breakpoints or log points are
dominated by calls to onNewScript. This suppresses those.

Depends on D138201

Attachment #9263596 - Attachment description: WIP: Bug 1752925 - Suppress new script notifications for smart breakpoints → Bug 1752925 - Suppress new script notifications for smart breakpoints
Attachment #9263596 - Attachment description: Bug 1752925 - Suppress new script notifications for smart breakpoints → WIP: Bug 1752925 - Suppress new script notifications for smart breakpoints

The severity field is not set for this bug.
:nchevobbe, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(nchevobbe)
Severity: -- → S3
Flags: needinfo?(nchevobbe)
Priority: -- → P2
Attachment #9263596 - Attachment description: WIP: Bug 1752925 - Suppress new script notifications for smart breakpoints → Bug 1752925 - Suppress new script notifications for smart breakpoints r?arai

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dthayer, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(dothayer)
Flags: needinfo?(arai.unmht)
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39a80fe0264f
Suppress new script notifications for smart breakpoints r=arai
Flags: needinfo?(dothayer)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: