1752992 - [Linux] Use unmap gtk signal to release window resources

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Right now we release window resources on unrealize gtk signal. That's suboptimal as unrealize is called on application quit. Let's try to use onmap and release window resources when window is hidden.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1752992 [Linux] Use unmap gtk signal to release window resources r?emilio

Right now we release window resources on unrealize gtk signal which is suboptimal as unrealize is called on application quit.
In this patch we:

• release window resources on unmap gtk signal when widget is hidden
• don't fail when mGdkWindow is null

Comment 2

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=a0ac372b1b62762475373670852c908a262494cd

Comment 3

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:stransky, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

That fails with tests and I don't know how to fix that (if that's even possible).

Comment 5

[Martin Stránský [:stransky] (ni? me)]

We can't destroy compositor until window itself is destroyed.