1753029 - Don't re-parent iframe nodeFront if retrieved target is the original one

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

In the past, we had several cases (e.g. Bug 1752342) where the target we retrieved for fetching an iframe children is in fact the exact same one that was already used to fetch the iframe itself.
And then, since we're trying to re-parent the iframe node front, we're causing infinite loops and crashes in the UI.
While we should fix those edge cases where we get the wrong target, we should at least limit the damage and avoid reparenting when we get an obviously incorrect target

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1753029 - [devtools] Add safe guard to avoid reparenting iframe nodeFront with wrong target. r=jdescottes.

This can be seen as a hot fix for Bug 1752342. Here we're not fixing the
root cause of the issue, but rather adding a protection mecanism so we don't
completely crash/freeze the inspector/the browser.
A follow-up bug will take care of Bug 1752342.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/981f815e26f9
[devtools] Add safe guard to avoid reparenting iframe nodeFront with wrong target. r=jdescottes.

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/981f815e26f9