1753033 - [wayland] Consider changing default kinetic scroll mode from page scrolling to pixel scrolling

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1752862 comment 12 and following. If this is something people find in need to change frequently, we should consider tweaking the default.

The page delta mode is more similar to other GTK apps, but for the web where there are a lot of scrollers it might not be a good default. The pixel delta mode is more similar to what GNOME web does, and it seems fast enough in my experience.

Either way filing this at least for tracking this potential behavior change.

Comment 1

[Asif Youssuff]

It seems to me that the GNOME Web may be doing it wrong if Firefox matches other GTK apps - and if users prefer that GTK does it more like GNOME Web, they ought to work with GNOME upstream to get that preference reflected. It is nice that we now have an option, but I would consider it a regression to default to a setting that is unlike the platform.

Just my 2¢.

Comment 2

[two]

GTK apps scroll the same as Epiphany, Firefox is much faster

Comment 3

[Val Packett]

Hi, the person who originally implemented the scrolling with the wrong mode only here :)

It's been a year since the original discussions and looks like everyone has forgotten about it, oops :/

Was just talking with a friend who was trying Linux out and complained about this:

[scrolling] was just easily 5x worse in firefox. everything was too fast and kept scrolling too long after releasing

Please do flip the default to apz.gtk.kinetic_scroll.mode=2, everyone liked it in the Bug 1752862 discussion!

I would also suggest apz.fling_friction=0.004-if-gtk, and apz.gtk.kinetic_scroll.pixel_mode_multiplier=25 seems to be what people have agreed on from that previous discussion, but those are subtler and not nearly as crucial as the mode.

Comment 4

[Botond Ballo [:botond]]

Heh, I'm used to the faster speed now and the pref changes in the previous comment feel quite slow :) But that's probably just familiarity bias rather than the current defaults being objectively better.

So, yes, I'm open to changing the defaults. Maybe we can start with just flipping delta_mode on the Nightly branch and see what feedback we get?

Would you like to write a patch?

Comment 5

[Val Packett]

I did also like fast speed, but it should be in line with regular GTK apps and shouldn't shock new users by feeling 5x faster that them…

Would you like to write a patch?

I don't currently have a dev setup sooo no..

Comment 6

[two]

kept scrolling too long after releasing

this is probably another thing
in gtk, kinetic scrolling stops after you put a finger on the touchpad (zwp_pointer_gesture_hold_v1 event), but in firefox it doesn't, you have to wait

Comment 7

[Alexander Browne]

in gtk, kinetic scrolling stops after you put a finger on the touchpad (zwp_pointer_gesture_hold_v1 event), but in firefox it doesn't, you have to wait

In GTK 4, and Firefox uses GTK 3. So either someone need to add it to GTK 3 or Firefox needs to use to GTK 4.

Comment 8

[Botond Ballo [:botond]]

(In reply to Alexander Browne from comment #7)

in gtk, kinetic scrolling stops after you put a finger on the touchpad (zwp_pointer_gesture_hold_v1 event), but in firefox it doesn't, you have to wait

In GTK 4, and Firefox uses GTK 3. So either someone need to add it to GTK 3 or Firefox needs to use to GTK 4.

Yeah. We have bug 1568722 open about this, and like you say it's blocked on hold gestures being backported to GTK 3. It would be great if that happened; as I mentioned in this comment, we only need a backport of the GDK layer of hold gestures, not the whole thing.

Comment 9

[:ren]

you can assign it to me if its still open botond

Comment 10

[Botond Ballo [:botond]]

(In reply to renevietnam29 from comment #9)

you can assign it to me if its still open botond

Sure!

Do you have a local build of Firefox already? If not, you can find instructions here.

As discussed in comment 4, we are initially only looking to change the value of the apz.gtk.pangesture.delta_mode pref, to 2 (pixel mode), and only on the Nightly branch. You can see an example of making a pref value conditional on Nightly here.

Comment 11

[:ren]

yes , I have a build. Ok I'll write a patch and you can check it from there

Comment 12

[:ren]

Attachment: Bug 1753033 - Change default kinetic scroll mode on Linux on the Nighly channel. r?botond

Depends on D184620

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f51f44f5da6
Change default kinetic scroll mode on Linux on the Nighly channel. r=botond

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2f51f44f5da6

Comment 15

[Botond Ballo [:botond]]

I filed bug 1851258 as a follow-up for potentially rolling out this change to the release channel.

Regressions from this change like bug 1849201 will need to be fixed before that happens.