1753047 - Bootstrap / toolchains fail in git checkout without origin remote

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

My remote is called mozilla (I guess at some point I git remote rename origin mozilla or something).

$ mach artifact toolchain --bootstrap --from-build linux64-clang-tidy                                                                                                                                                                    
/home/emilio/src/moz/gecko/mach:81: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils
error: No such remote 'origin'
Error running mach:

    ['artifact', 'toolchain', '--bootstrap', '--from-build', 'linux64-clang-tidy']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file artifact| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

subprocess.CalledProcessError: Command '('/usr/bin/git', 'remote', 'get-url', 'origin')' returned non-zero exit status 2.

  File "/home/emilio/src/moz/gecko/python/mozbuild/mozbuild/artifact_commands.py", line 380, in artifact_toolchain
    tasks = toolchain_task_definitions()
  File "/home/emilio/src/moz/gecko/python/mozbuild/mozbuild/toolchains.py", line 19, in toolchain_task_definitions
    toolchains = load_tasks_for_kind(params, "toolchain", root_dir=root_dir)
  File "/home/emilio/src/moz/gecko/taskcluster/gecko_taskgraph/generator.py", line 490, in load_tasks_for_kind
    for task in tgg.full_task_set
  File "/home/emilio/src/moz/gecko/taskcluster/gecko_taskgraph/generator.py", line 163, in full_task_set
    return self._run_until("full_task_set")
  File "/home/emilio/src/moz/gecko/taskcluster/gecko_taskgraph/generator.py", line 435, in _run_until
    k, v = next(self._run)
  File "/home/emilio/src/moz/gecko/taskcluster/gecko_taskgraph/generator.py", line 264, in _run
    parameters = self._parameters(graph_config)
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/parameters.py", line 318, in get_parameters
    parameters = load_parameters_file(
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/parameters.py", line 274, in load_parameters_file
    return Parameters(strict=strict, repo_root=repo_root, **overrides)
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/parameters.py", line 121, in __init__
    kwargs = Parameters._fill_defaults(repo_root=repo_root, **kwargs)
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/parameters.py", line 161, in _fill_defaults
    defaults.update(fn(repo_root))
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/parameters.py", line 65, in _get_defaults
    "base_repository": repo.get_url(),
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/util/vcs.py", line 135, in get_url
    return self.run("remote", "get-url", remote).strip()
  File "/home/emilio/src/moz/gecko/third_party/python/taskcluster_taskgraph/taskgraph/util/vcs.py", line 28, in run
    return subprocess.check_output(cmd, cwd=self.path, universal_newlines=True)
  File "/usr/lib64/python3.10/subprocess.py", line 420, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,

Sentry event ID: 30d1dc1178a440a180da0ff9b9868144
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

Comment 1

[Andrew Halberstadt [:ahal]]

I'm out sick today, so yet another backout is probably best. Fwiw I even set up a git-cinnabar clone to test it this time, but I guess my remote is called origin, sigh :)

There's no need to even be calling get_url here, we can hardcode the params to what the old values used to be in Gecko. The only gotcha is that the fix will need to happen in the upstream taskgraph repo. I can publish a release to pypi if anyone wants to try to submit a fix there, or I can try and get a fix up at some point by tonight, but otherwise I guess back it out again

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'm ok not backing out if I'm the only one with this problem for now, fwiw, can wait for a few days typing origin, I'll probably have a few misses on muscle memory but...

I might try to do that if this gets too annoying :)

Comment 3

[Andrew Halberstadt [:ahal]]

jgraham was also hitting it at least, it's up to you. There's no particular rush on having that bug fixed.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1753047 - [taskgraph] Hardcode repo defaults. r=ahal

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1753047 - Catch call to repo.get_url() and use an empty string if there's an exception, r?#releng-reviewers!

This call will raise if there's no remote called "origin". If this happens, an
empty string may still work as a default (and in Gecko we'll be overriding it
anyway).

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1753047 - Version bump to taskgraph 1.1.4, r?#releng-reviewers!

Depends on D137556

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/taskgraph/rev/f1ff40653baa
Catch call to repo.get_url() and use an empty string if there's an exception, r=releng-reviewers,jmaher
https://hg.mozilla.org/ci/taskgraph/rev/78b8548bcd52
Version bump to taskgraph 1.1.4, r=releng-reviewers,jmaher

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1753047 - [taskgraph] Use hardcoded values for default 'base_repository' and 'head_repository' parameters, r?#releng-reviewers!

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1753047 - Update vendored taskgraph to 1.1.4, r?#releng-reviewers!

Depends on D137571

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746414

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d93bf3a612f5
[taskgraph] Use hardcoded values for default 'base_repository' and 'head_repository' parameters, r=releng-reviewers,jmaher,aki
https://hg.mozilla.org/integration/autoland/rev/111381fbf62d
Update vendored taskgraph to 1.1.4, r=releng-reviewers,jcristau

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d93bf3a612f5
https://hg.mozilla.org/mozilla-central/rev/111381fbf62d