Closed Bug 1753134 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32653 - AppHistory bfcache support

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32653 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32653
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

AppHistory bfcache support

Currently, with appHistory and bfcache both enabled, appHistory's
entries() arrays are not updated when a navigation is served from
bfcache. It keeps the same appHistory.entries() that it had when the
document was put into bfcache, but the entries() almost certainly have
changed in the meantime.

This CL adds a new mojo call during commit to update the entries in
the renderer when restoring from bfcache.

Fixed: 1241655
Change-Id: I9c49312ccbbec714f751f3b59c8d1f05edb024fd
Reviewed-on: https://chromium-review.googlesource.com/3277336
WPT-Export-Revision: fcabc28a3a27e9b23dc81e4938e0199051df7543

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 19 tests and 1 subtests

Status Summary

Firefox

OK : 11[Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt] 12[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug] 18[GitHub]
PASS : 21[Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt] 22[Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug] 24[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, GitHub]
FAIL : 3[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 4[GitHub]
PRECONDITION_FAILED: 6[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 8[Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 14[GitHub]
TIMEOUT : 2

Chrome

OK : 18
PASS : 16
FAIL : 2
PRECONDITION_FAILED: 24
TIMEOUT : 2

Safari

OK : 16
PASS : 16
FAIL : 20
PRECONDITION_FAILED: 1
TIMEOUT : 6
NOTRUN : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/browsers/browsing-the-web/back-forward-cache/eligibility/inflight-fetch-cors.html
Eligibility (in-flight fetch): CORS failed when in BFCache: PRECONDITION_FAILED linked bug:Bug 1752500
/html/browsers/browsing-the-web/back-forward-cache/events.html
beforeunload: PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PRECONDITION_FAILED [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] linked bug:Bug 1754624

New Tests That Don't Pass

/app-history/app-history-entry/entries-after-bfcache-in-iframe.html
entries() in an iframe must be updated after navigating back to a bfcached page: FAIL (Chrome: PRECONDITION_FAILED, Safari: FAIL)
/app-history/app-history-entry/entries-after-bfcache.html
entries() must contain the forward-history page after navigating back to a bfcached page: FAIL (Chrome: PRECONDITION_FAILED, Safari: FAIL)
/app-history/per-entry-events/dispose-after-bfcache.html
entries() must contain the forward-history page after navigating back to a bfcached page: FAIL (Chrome: PRECONDITION_FAILED, Safari: FAIL)
/html/browsers/browsing-the-web/back-forward-cache/eligibility/broadcast-channel.html: OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: OK)
Eligibility (BroadcastChannel closed in the pagehide event): PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: PASS)
/html/browsers/browsing-the-web/back-forward-cache/eligibility/inflight-fetch-cors.html
Eligibility (in-flight fetch): CORS succeeded when in BFCache: PRECONDITION_FAILED (Chrome: PASS, Safari: FAIL)
Eligibility (in-flight fetch): CORS failed when in BFCache: PRECONDITION_FAILED (Chrome: PASS, Safari: PASS)
/html/browsers/browsing-the-web/back-forward-cache/eligibility/inflight-fetch-redirects.html
Eligibility (in-flight fetch): Redirect header received when in BFCache: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
Eligibility (in-flight fetch): Redirect header received when in BFCache w/ CSP passing: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
Eligibility (in-flight fetch): Cross-origin redirect header received when in BFCache: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
Eligibility (in-flight fetch): Cross-origin redirect header received when in BFCache w/ CSP failing: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PASS)
/html/browsers/browsing-the-web/back-forward-cache/events.html
beforeunload: PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PRECONDITION_FAILED [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
unload: PASS [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PRECONDITION_FAILED [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: PRECONDITION_FAILED, Safari: PASS)
/html/browsers/browsing-the-web/back-forward-cache/eligibility/inflight-fetch-1.html
Eligibility (in-flight fetch): Header received before BFCache and body received when in BFCache: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
Eligibility (in-flight fetch): Header received before BFCache and body received after BFCache: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
/html/browsers/browsing-the-web/back-forward-cache/eligibility/inflight-fetch-2.html
Eligibility (in-flight fetch): Header and body received when in BFCache: PRECONDITION_FAILED (Chrome: PASS, Safari: FAIL)
Eligibility (in-flight fetch): Header received when in BFCache and body received after BFCache: PRECONDITION_FAILED (Chrome: PASS, Safari: FAIL)
Eligibility (in-flight fetch): Header and body received after BFCache: PRECONDITION_FAILED (Chrome: PASS, Safari: FAIL)
/html/browsers/browsing-the-web/back-forward-cache/focus.html
Focus should be kept when page gets into and out of BFCache: FAIL (Chrome: FAIL, Safari: PASS)
/performance-timeline/navigation-counter.tentative.html
bfcache counter test: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: PRECONDITION_FAILED)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2484697a57ca
[wpt PR 32653] - AppHistory bfcache support, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d331195e082b
[wpt PR 32653] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.