1753140 - Background animation is not smooth on sub.v1.mk

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Ksenia Berezina [:ksenia]]

​​### Basic information
This was originally reported in https://github.com/webcompat/web-bugs/issues/98601

Steps to Reproduce:
Visit https://sub.v1.mk/ in Firefox Nightly 98.0a1 (2022-01-26) and observe the background
(the canvas element in the background is only visible when Firefox is in light theme mode)

Expected Results:
Animation is smooth

Actual Results:
Animation is not smooth

---

Performance recording (profile)

Profile URL: https://share.firefox.dev/35r1pLt

System configuration:

OS version: Windows 10 Pro with webrender enabled

Comment 1

[Mayank Bansal]

https://share.firefox.dev/3ukjFka
Profile looks Canvas-y

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Lee Salzman [:lsalzman]]

Bob, ideas here? I am not seeing anything in the profile that jumps out at me other than some keyed mutex waits on the canvas, but I am having trouble identifying anything in the profile tracks that would look like it is actually doing any kind of heavy intermittent processing at all.

Comment 4

[Bob Owen (:bobowen)]

(In reply to Lee Salzman [:lsalzman] from comment #3)

Bob, ideas here? I am not seeing anything in the profile that jumps out at me other than some keyed mutex waits on the canvas, but I am having trouble identifying anything in the profile tracks that would look like it is actually doing any kind of heavy intermittent processing at all.

It's all happening during DrawTargetD2D1::FlushInternal and those mutex waits are just the content process waiting for the GPU canvas thread to catch up.
If I turn off remote canvas I get basically the same thing with the content process main thread waiting on the flushes.

In both cases about 30% seems to be in NtFreeVirtualMemory from ~TransformableTessellationStore, which seems a bit crazy.

Comment 5

[Dennis Schubert [:denschub]]

Seems to be a minor perf issue, not a webcompat issue.

Comment 6

[Mayank Bansal]

This is fixed by gpu-canvas: https://share.firefox.dev/4cfcNH9
Still repros with d2d-canvas: https://share.firefox.dev/4dtWYxg

Comment 7

[Mayank Bansal]

Latest profile: https://share.firefox.dev/3EvOh9y
Should this bug be closed as fixed?

Comment 8

[Bob Owen (:bobowen)]

With no response from reporter, I'm going to mark this as fixed due to comment 6 and comment 7.