1753411 - Deduplicate a lot of the X11/Wayland clipboard code.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1753411 - Deduplicate a bunch of the X11 vs. Wayland clipboard code. r=stransky

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1753411 - Remove wayland clipboard mutex. r=stransky

Not sure why would it be needed now.

Depends on D137735

Comment 3

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=ddbf05855b5d61bdeefe3985c8db5427322732a4

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Why do you think we don't need the mutex?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Why would we need it? Do we call it off main thread? Each async GTK request is paired with a Request object now, so even if you called multiple times to GetTargets etc it should behave correctly, afaict. And we don't call this code from different threads so the mutex is just protecting from reentrancy, right?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

X11 code is pretty similar to the current Wayland code, and it doesn't use a mutex, nor I know why would it.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

Why would we need it? Do we call it off main thread? Each async GTK request is paired with a Request object now, so even if you called multiple times to GetTargets etc it should behave correctly, afaict. And we don't call this code from different threads so the mutex is just protecting from reentrancy, right?

Yes, mutex is here for reentrancy.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/26e996ca80e3
https://hg.mozilla.org/mozilla-central/rev/e987da6babdd
https://hg.mozilla.org/mozilla-central/rev/e24e54274599