Closed Bug 1753424 Opened 10 months ago Closed 8 months ago

Ability to run more than one Utility Process

Categories

(Core :: Security: Process Sandboxing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

(Blocks 2 open bugs)

Details

Attachments

(6 files, 3 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
2.72 KB, text/plain
willkg
: data-review+
Details
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Severity: -- → S3
Priority: -- → P1
Depends on: 1755437
Blocks: 1755316
Blocks: 1532644
Blocks: 1756802
Depends on: 1756984
Attachment #9265915 - Attachment description: WIP: Bug 1753424 - Dont always a UtilityProcessManager from FOG → WIP: Bug 1753424 - Dont always instantiate a UtilityProcessManager from FOG
Depends on: 1758715

Comment on attachment 9265915 [details]
WIP: Bug 1753424 - Dont always instantiate a UtilityProcessManager from FOG

Revision D139966 was moved to bug 1758715. Setting attachment 9265915 [details] to obsolete.

Attachment #9265915 - Attachment is obsolete: true
Attachment #9265687 - Attachment description: WIP: Bug 1753424 - Remove unused UtilityProcessParent and UtilityProcessManager methods → WIP: Bug 1753424 - Remove unused UtilityProcessParent and UtilityProcessManager code
Attachment #9265688 - Attachment description: WIP: Bug 1753424 - Support multiple Utility → WIP: Bug 1753424 - Support running multiple UtilityProcess
Attachment #9267232 - Flags: data-review? → data-review?(willkg)

Comment on attachment 9267232 [details]
data review for https://bugzilla.mozilla.org/attachment.cgi?id=9267227

  1. Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

    Yes.

  2. Is there a control mechanism that allows the user to turn the data collection on and off?

    Crash report collection is opt-in.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?

    Permanent. alissy@mozilla.com

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

    Category 1.

  5. Is the data collection request for default-on or default-off?

    default-off

  6. Does the instrumentation include the addition of any new identifiers?

    No.

  7. Is the data collection covered by the existing Firefox privacy notice?

    Yes.

  8. Does there need to be a check-in in the future to determine whether to renew the data?

    No.

  9. Does the data collection use a third-party collection tool?

    No.

Looks good!

Attachment #9267232 - Flags: data-review?(willkg) → data-review+
Attachment #9267227 - Attachment description: WIP: Bug 1753424 - Add SandboxingKind for UtilityProcess crash annotations → Bug 1753424 - Add SandboxingKind for UtilityProcess crash annotations r?gsvelto!
Attachment #9265687 - Attachment description: WIP: Bug 1753424 - Remove unused UtilityProcessParent and UtilityProcessManager code → Bug 1753424 - Remove unused UtilityProcessParent and UtilityProcessManager code r?nika!
Attachment #9267228 - Attachment description: WIP: Bug 1753424 - Update UtilityProcess browser tests with sandboxingKind → Bug 1753424 - Update UtilityProcess browser tests with sandboxingKind r?nika!
Attachment #9267229 - Attachment description: WIP: Bug 1753424 - Update SandboxTest code with sandboxingKind → Bug 1753424 - Update SandboxTest code with sandboxingKind r?jld!
Attachment #9265688 - Attachment description: WIP: Bug 1753424 - Support running multiple UtilityProcess → Bug 1753424 - Support running multiple UtilityProcess r?nika!
Attachment #9267228 - Attachment is obsolete: true
Blocks: 1761054
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f244f2eb2de
Remove unused UtilityProcessParent and UtilityProcessManager code r=nika
https://hg.mozilla.org/integration/autoland/rev/f27fbfb9e8f1
Add SandboxingKind for UtilityProcess crash annotations r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/4df499ef4647
Update SandboxTest code with sandboxingKind r=jld
https://hg.mozilla.org/integration/autoland/rev/0892c1d3c379
Ensure UtilityProcessChild singleton is mutex-protected r=nika
https://hg.mozilla.org/integration/autoland/rev/e2b40064eb59
Support running multiple UtilityProcess r=nika
Flags: needinfo?(lissyx+mozillians)
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4748652694c7
Remove unused UtilityProcessParent and UtilityProcessManager code r=nika
https://hg.mozilla.org/integration/autoland/rev/97b3fd69185b
Add SandboxingKind for UtilityProcess crash annotations r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/cce723862a92
Update SandboxTest code with sandboxingKind r=jld
https://hg.mozilla.org/integration/autoland/rev/911060d2bd8e
Ensure UtilityProcessChild singleton is mutex-protected r=nika
https://hg.mozilla.org/integration/autoland/rev/d62c1e5d1881
Support running multiple UtilityProcess r=nika

Some linux builds were busted and somehow the backout got incomplete
making it impossible to reland properly through lando.

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/930136daf858
Hotfix UtilityProcessImpl for autoland build bustage r=bustage-fix CLOSED TREE

Backed out for causing build bustages.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/security/sandbox/common/test/SandboxTest.cpp:125:51: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(lissyx+mozillians)
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8acc944e6e92
Remove unused UtilityProcessParent and UtilityProcessManager code r=nika
https://hg.mozilla.org/integration/autoland/rev/2b61d6018a04
Add SandboxingKind for UtilityProcess crash annotations r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/cc1c31464102
Update SandboxTest code with sandboxingKind r=jld
https://hg.mozilla.org/integration/autoland/rev/014d35dc2826
Ensure UtilityProcessChild singleton is mutex-protected r=nika
https://hg.mozilla.org/integration/autoland/rev/d49ef2295e1f
Support running multiple UtilityProcess r=nika
No longer blocks: 1756802
Depends on: 1756802
Attachment #9269550 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.