1753702 - Some favicons showing 'broken image' icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Sam Johnson]

Attachment: Example

In today's nightly, there has been a regression with the display of favicons for some webpages. For example, visiting https://medium.com/@pavloosadchyi/terraform-patterns-and-tricks-i-use-every-day-117861531173 shows the 'broken image' icon in the tab bar. Prior to today's nightly, this did not occur.

Guessing this was regressed by bug 1718220.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1753702 - Use the default icon for broken favicons. r=dao

Before that we would just paint transparent. I can do that if you want,
but this seems slightly better.

Comment 2

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/57b12b5733c3

Comment 3

[Monica Chiorean]

Attachment: Screenshot_98.0b2.png

I was able to reproduce the issue on Win10x64 using build 98.0a1 (20220204214157).
I verified on Win10/Ubuntu20.4/Mac10.13 using builds 98.0b2(8feb2022) and 99.0a1(9feb2022) that the favicon is not broke like on reported build but I not sure that the used favicon is the correct one.
Based on attached screenshot can you please confirm this is the expected favicon? Thank you.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

That's the default favicon we use so yeah, that's the expected behavior.

Comment 5

[Monica Chiorean]

Closing issue based on comment #4.