1753733 - Replace arbitrary timeouts in tests with waitForCondition

Status: RESOLVED DUPLICATE of bug 1655600

(Toolkit :: Form Autofill, task, P3)

Description

[Sergey Galich [:serg]]

We have too many places like this one https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_doorhanger.js#189 when we wait 1 second for focus or change of value happen in the element. Even when test runs fast, we lose almost 1 second just waiting. It accumulates to at least 30 seconds of test runs for no benefit.

Lets replace multiple copy/paste lines of code with a specialized function to focus-element-and-wait or change-element-value-and-wait. We can use waitForCondition() to reduce time loss.

Comment 1

[Sam Foster [:sfoster] (he/him)]

See the eslint-disable mozilla/no-arbitrary-setTimeout which disables the lint error the setTimeout would normally produce. We could probably watch input events and resolve a promise when we get the expected value. waitForCondition is a bit of a blunt tool but would still be an improvement here.

Comment 2

[Sergey Galich [:serg]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)

See the eslint-disable mozilla/no-arbitrary-setTimeout which disables the lint error the setTimeout would normally produce. We could probably watch input events and resolve a promise when we get the expected value. waitForCondition is a bit of a blunt tool but would still be an improvement here.

Thanks Sam, that is helpful!

Comment 3

[Sergey Galich [:serg]]

Attachment: WIP: Bug 1753733 - Replace arbitrary timeouts in tests with waitForCondition