Closed
Bug 1753739
Opened 4 years ago
Closed 4 years ago
Pre-commit linting hook ModuleNotFoundError: No module named 'mach'
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox-esr91 unaffected, firefox97 unaffected, firefox98 fixed, firefox99 fixed)
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox97 | --- | unaffected |
| firefox98 | --- | fixed |
| firefox99 | --- | fixed |
People
(Reporter: Mardak, Assigned: Mardak)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Similar to bug 1699188 likely regressed by bug 1750693, which added from mach.util import to_optional_path:
Traceback (most recent call last):
File ".git/hooks/pre-commit", line 22, in <module>
from mozversioncontrol import get_repository_object, InvalidRepoPath
File "tools/lint/../../python/mozversioncontrol/mozversioncontrol/__init__.py", line 16, in <module>
from mach.util import to_optional_path
ModuleNotFoundError: No module named 'mach'
| Assignee | ||
Updated•4 years ago
|
Summary: Pre-commit linting hook ModuleNotFoundError: No module named 'jsmin' → Pre-commit linting hook ModuleNotFoundError: No module named 'mach'
| Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Attachment #9262430 -
Attachment description: Bug 1753739 - [mozlint] Include mach now that mozversioncontrol uses mach.util r?ahal → Bug 1753739 - [mozlint] Include mach now that mozversioncontrol uses mach.util r?mhentges r=ahal!
Comment 2•4 years ago
|
||
Type: task → defect
Updated•4 years ago
|
Has Regression Range: --- → yes
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0283b83ef173
[mozlint] Include mach now that mozversioncontrol uses mach.util r=ahal,mhentges
Updated•4 years ago
|
Keywords: regression
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Comment 5•4 years ago
|
||
Set release status flags based on info from the regressing bug 1750693
status-firefox97:
--- → unaffected
status-firefox98:
--- → affected
status-firefox-esr91:
--- → unaffected
Comment 6•3 years ago
|
||
| bugherder uplift | ||
Flags: in-testsuite-
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•