Closed Bug 1753757 Opened 2 years ago Closed 2 years ago

Eliminate preprocessor %includes from Downloads stylesheets

Categories

(Firefox :: Theme, task)

Product:
Firefox
Component:
Theme
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: sfoster, Assigned: bigiri)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

Bug 1753757 - Eliminate preprocessor %includes from Downloads stylesheets r=Dao!
48 bytes, text/x-phabricator-request
Details | Review

Replace the %includes with either @import or by inlining the included stylesheet. See bug 1659584 for details. This bug should cover:

  • browser/themes/{platform}/downloads/downloads.css
    • browser/themes/shared/downloads/downloads.inc.css
      • browser/themes/shared/downloads/progressmeter.inc.css
      • browser/themes/shared/downloads/download-blockedStates.inc.css
  • browser/themes/{platform}/downloads/allDownloadsView.css
    • browser/themes/shared/downloads/allDownloadsView.inc.css
      • browser/themes/shared/downloads/progressmeter.inc.css
      • browser/themes/shared/downloads/download-blockedStates.inc.css

Note that browser/themes/shared/downloads/indicator.inc.css styles the download toolbarbutton and is included directly from browser.inc.css, so is not in scope here.

Component: Themes → Theme
Product: Toolkit → Firefox
Blocks: 1753761
Blocks: 1753762
No longer blocks: 1753762
No longer blocks: 1753761
See Also: → 1752832

Replaced preprocessor includes with css imports

Assignee: nobody → bigiri
Status: NEW → ASSIGNED
Attachment #9265015 - Attachment description: Bug 1753757 - Eliminate preprocessor %includes from Downloads stylesheets r=Dao! → WIP: Bug 1753757 - Eliminate preprocessor %includes from Downloads stylesheets
Attachment #9265015 - Attachment description: WIP: Bug 1753757 - Eliminate preprocessor %includes from Downloads stylesheets → Bug 1753757 - Eliminate preprocessor %includes from Downloads stylesheets r=Dao!
Whiteboard: [fidefe-2022-mr1-css-linting]
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b547c1a2ef61
Eliminate preprocessor %includes from Downloads stylesheets r=dao

https://hg.mozilla.org/mozilla-central/rev/b547c1a2ef61

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: