Closed
Bug 1753760
Opened 2 years ago
Closed 2 years ago
Eliminate preprocessor %includes from sidebar stylesheets
Categories
(Firefox :: Theme, task)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: sfoster, Assigned: bigiri)
References
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(2 files)
Replace the %includes with either @import or by inlining the included stylesheets. See bug 1659584 for details. This bug should cover:
- browser/themes/{platform}/syncedtabs/sidebar.css
- browser/themes/shared/syncedtabs/sidebar.inc.css
- browser/themes/{platform}/places/sidebar.css
- browser/themes/shared/places/sidebar.inc.css
|
Reporter | |
Updated•2 years ago
|
Component: Themes → Theme
Product: Toolkit → Firefox
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → bigiri
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
- Replaced preprocessor includes with CSS imports for places/sidebar
- Replaced preprocessor includes with media queries for syncedtabs/sidebar since the platform specific CSS files were small.
|
||
Updated•2 years ago
|
Attachment #9265947 -
Attachment description: Bug 1753760 - Remove preprocessor includes from sidebar r=Dao! → WIP: Bug 1753760 - Remove preprocessor includes from sidebar r=Dao!
|
|
||
Updated•2 years ago
|
Attachment #9265947 -
Attachment description: WIP: Bug 1753760 - Remove preprocessor includes from sidebar r=Dao! → Bug 1753760 - Remove preprocessor includes from sidebar r=Dao!
|
|
Assignee | |
Comment 2•2 years ago
|
||
Renamed .inc.css files to .css so that the manifest doesn't alter file names.
Depends on D139990
|
|
||
Updated•2 years ago
|
Attachment #9267257 -
Attachment description: Bug 1753760 - Remove preprocessor includes from sidebar r=Dao! → Bug 1753760 - Rename inc.css files to .css r=Dao!
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8394e008936b Remove preprocessor includes from sidebar r=dao https://hg.mozilla.org/integration/autoland/rev/6630c5fd5a15 Rename inc.css files to .css r=dao
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8394e008936b
https://hg.mozilla.org/mozilla-central/rev/6630c5fd5a15
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•