Eliminate preprocessor %includes from compact theme stylesheets
Categories
(Firefox :: Theme, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: sfoster, Assigned: bigiri)
References
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(2 files)
Replace the %includes with either @import or by inlining the included stylesheet. See bug 1659584 for details. This bug should cover:
- browser/themes/{platform}/compacttheme.css
- browser/themes/shared/compacttheme.inc.css
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Replaced preprocessor includes with platform media queries.
|
|
Assignee | |
Comment 2•2 years ago
|
||
How can I test this? Also, do the media queries -moz-windows-compositor: 0 and -moz-windows-glass restrict the platform to Windows?
|
||
Updated•2 years ago
|
|
Reporter | |
Comment 3•2 years ago
•
|
||
(In reply to Bernard Igiri from comment #2)
How can I test this? Also, do the media queries
-moz-windows-compositor: 0and-moz-windows-glassrestrict the platform to Windows?
I answered in phabricator. I would think -moz-windows-compositor: 0 and -moz-windows-glass would only match for windows, but I think regardless all the contents of the windows/compactheme.css should go inside a @media ( moz-platform: windows ) block. Meaning those should nest inside.
compactheme.css is loaded when you pick the dark or light theme. You can confirm that by checking in the inspector for rules that apply to #urlbar. Obviously the bulk of this stylesheet is overrides for windows, so you'll want to check there to verify.
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
Renamed compactthemes.inc.css to a more accurate name.
Depends on D140052
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/006e488e84ad Remove preprocessor includes from compact theme stylesheets r=dao https://hg.mozilla.org/integration/autoland/rev/334ecc769a3a Rename compacttheme.inc.css r=dao,Itiel
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/006e488e84ad
https://hg.mozilla.org/mozilla-central/rev/334ecc769a3a
Description
•