1753765 - Eliminate preprocessor %includes from Customizeable PanelUI stylesheets

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Sam Foster [:sfoster] (he/him)]

Replace the %includes with either @import or by inlining the included stylesheets. See bug 1659584 for details. This bug should cover:

• browser/themes/{platform}/customizableui/panelUI.css
  • browser/themes/shared/customizableui/panelUI.inc.css

Comment 1

[Bernard Igiri]

Attachment: Bug 1753765 - Remove preprocessor includes from Customizeable PanelUI r=Dao!

• Replaced preprocessor includes with CSS imports
• Removed .inc from CSS files names where all preprocessor code was removed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c83c8662c973
Remove preprocessor includes from Customizeable PanelUI r=dao

Comment 3

[Marian-Vasile Laza]

Backed out changeset c83c8662c973 (Bug 1753765) for causing bc failures on browser_parsable_css.js.
Backout link
Push with failures
Failure Log

Comment 4

[:Gijs (he/him)]

(In reply to Marian-Vasile Laza from comment #3)

Backed out changeset c83c8662c973 (Bug 1753765) for causing bc failures on browser_parsable_css.js.
Backout link
Push with failures
Failure Log

This is flagging up conditionals in panelUI.inc.css. You could either fix that here or just add a * to the jar.mn entry for the panelUI.inc.css file in the shared jar.mn, so that it gets preprocessed and the conditions in there continue to work.

Comment 5

[Bernard Igiri]

The updated patch including @Gijs' suggestion should resolve this error.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6d7a4d3a374
Remove preprocessor includes from Customizeable PanelUI r=dao

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a6d7a4d3a374