1753772 - Fission Android mochitest debug crash in SetDynamicToolbarMaxHeight

Status: RESOLVED FIXED

(GeckoView :: Sandboxing, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

A lot of debug mochitests fail on Android when run under fission this way. Fixing this might unblock a lot of tests.

e.g. https://treeherder.mozilla.org/logviewer?job_id=365794979&repo=try&lineNumber=45859

[task 2022-01-27T21:55:20.598Z] 21:55:20  WARNING -  PROCESS-CRASH | js/xpconnect/tests/mochitest/test_bug396851.html | application crashed [@ nsPresContext::SetDynamicToolbarMaxHeight(mozilla::gfx::IntCoordTyped<mozilla::ScreenPixel, int>)]
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  Mozilla crash reason: MOZ_ASSERT(IsRootContentDocumentCrossProcess())
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  Crash dump filename: /tmp/tmpkkid8oji/63041dc2-47ff-6e55-8e33-96739a121566.dmp
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  Operating system: Android
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -                    0.0.0 Linux 3.10.0+ #260 SMP PREEMPT Fri May 19 12:48:14 PDT 2017 x86_64
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  CPU: amd64
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -       family 6 model 6 stepping 3
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -       4 CPUs
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  Crash reason:  SIGSEGV / SEGV_MAPERR
[task 2022-01-27T21:55:20.598Z] 21:55:20     INFO -  Crash address: 0x0
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -  Process uptime: not available
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -  Thread 11  (crashed)
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -   0  libxul.so!nsPresContext::SetDynamicToolbarMaxHeight(mozilla::gfx::IntCoordTyped<mozilla::ScreenPixel, int>) [nsPresContext.cpp:eec79349ec56f5054c807f3e9a97eaf05ac0857d : 2678 + 0x29]
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -      rax = 0x000071b0d3245520   rdx = 0x0000000000000004
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -      rcx = 0x000071b0d6902c60   rbx = 0x000071b0eedeb100
[task 2022-01-27T21:55:20.599Z] 21:55:20     INFO -      rsi = 0x000071b0d7205100   rdi = 0x000000000000001b
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -      rbp = 0x000071b0d7206250   rsp = 0x000071b0d7206220
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -       r8 = 0x000000000000ffff    r9 = 0x0000000000000000
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -      r10 = 0x000071b0f3a5b3d0   r11 = 0x0000000000000246
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -      r12 = 0x000071b0d7206268   r13 = 0x0000000000000000
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -      r14 = 0x0000000000000000   r15 = 0xaaaaaaaaaaaaaaaa
[task 2022-01-27T21:55:20.600Z] 21:55:20     INFO -      rip = 0x000071b0ce854832

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1753772 - Don't call SetDynamicToolbarMaxHeight for non-root BrowserParent.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1753772 - Add xorigin-tests to android test runner.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f3546879831
Don't call SetDynamicToolbarMaxHeight for non-root BrowserParent. r=hiro

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1f3546879831

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7550c67c2a1
Add xorigin-tests to android test runner. r=jmaher

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c7550c67c2a1

Comment 7

[Chris Peterson [:cpeterson]]

Moving Android Fission bugs to the new GeckoView::Sandboxing component.