1753919 - Remove copy situation of AndroidWebAuthnResult

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Makoto Kato [:m_kato]]

AndroidWebAuthnResult has copy constructor for HandleRegisterResult and HandleSignResult. Sicne AndroidWebAuthnResult is large object, we should remove copy constructor then use std::move.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1753919 - AndroidWebAuthnTokenManager uses GeckoResult directly instead of callback. r=#geckoview-reviewers

Since WebAuthnTokenManager uses GeckoReuslt, we can remove callback of WebAuthnTokenManager.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1753919 - Allow non-copy C++ object for GeckoResult paramenter. r=#geckoview-reviewers

Actually, we require that the parameter of promise by GeckoResult has copy
constructor. We should allow non-copy C++ class for this parameter.

Depends on D137973

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1753919 - Remove copy constructor from AndroidWebAuthnResult. r=#geckoview-reviewers

Let's remove copy situation of AndroidWebAuthnResult.

Depends on D137974

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/921e6784ee11
AndroidWebAuthnTokenManager uses GeckoResult directly instead of callback. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/dfc29f2b1a1f
Allow non-copy C++ object for GeckoResult paramenter. r=geckoview-reviewers,bholley,agi
https://hg.mozilla.org/integration/autoland/rev/b0faf7d51350
Remove copy constructor from AndroidWebAuthnResult. r=geckoview-reviewers,agi

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/921e6784ee11
https://hg.mozilla.org/mozilla-central/rev/dfc29f2b1a1f
https://hg.mozilla.org/mozilla-central/rev/b0faf7d51350