1753973 - pop3-js - messages over 50KB are not fully downloaded by default

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Magnus Melin [:mkmelin]]

I set up a new POP3 account. Some of the messages are not fully downloaded, but get the "Truncated!This message exceeded the Maximum Message Size set in Account Settings, so we have only downloaded the first few lines from the mail server." message.

I didn't change any defaults, so no such limitations should apply. Seems it's messages over 50KB.

Comment 1

[Magnus Melin [:mkmelin]]

Clicking the "Download the rest of the message." link doesn't work either.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1753973 - Fetch full message if server.limitOfflineMessageSize is false in Pop3Client.jsm. r=mkmelin

Comment 3

[Ping Chen [:rnons] (away)]

Good catch. "Download the rest of the message." works for me though.

Comment 4

[Magnus Melin [:mkmelin]]

For the "download the rest link" I just get this:

mailnews.pop3: Connecting to pop://pop.gmx.com:995 Pop3Client.jsm:122:18
mailnews.pop3: Connected Pop3Client.jsm:239:18
mailnews.pop3: S: +OK POP server ready H migmx107 1MA4fK-1nRoyL22Pa-00D85R

Pop3Client.jsm:274:18
mailnews.pop3: C: QUIT Pop3Client.jsm:425:20
mailnews.pop3: S: +OK POP server signing off

Pop3Client.jsm:274:18
mailnews.pop3: Connection closed. Pop3Client.jsm:297:18

Comment 5

[Ping Chen [:rnons] (away)]

Thanks. This happens when the message has been removed from the server. Seems the C++ code will remove this partial message if not found on server.

Comment 6

[Magnus Melin [:mkmelin]]

This message is still on the server - I can see it through IMAP. I have the settings not to remove stuff from the server set as well so it should not have removed it (which it correctly has not).

Comment 7

[Ping Chen [:rnons] (away)]

The code is https://searchfox.org/comm-central/rev/50d06c67e97daebd61b3da2b490c68e674a5ef97/mailnews/local/src/Pop3Client.jsm#185-186
Can you see if this uidl is still in popstate.dat and status should be b?
Also do a get messages request, is this uidl still in the UIDL response?

Comment 8

[Magnus Melin [:mkmelin]]

1MA4fK-1nRoyL22Pa-00D85R is not in popstate.dat.
It's not in the UIDL response either.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/996762d9ecf6
Fetch full message if server.limitOfflineMessageSize is false in Pop3Client.jsm. r=mkmelin

Comment 10

[Ping Chen [:rnons] (away)]

(In reply to Magnus Melin [:mkmelin] from comment #8)

It's not in the UIDL response either.

I guess many mail services have separate logic for pop3/imap connections. GMail has some special settings to keep mails for pop3.

Will send a patch to delete partial message not found on server.

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: Bug 1753973 - Delete partial message if not found on server in Pop3Client.jsm. r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad3ce437ca0d
Delete partial message if not found on server in Pop3Client.jsm. r=mkmelin