1754055 - Thunderbird 98.0a1 (2022-02-07) and 98.0b1/b2 Crash in [@ js::RunScript ] or [@ PromiseReactionJob ] after closing/shutdown

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

I updated Thunderbird 98.0a1 on Wayland from 2022-02-06 to 2022-02-07 using the Help > About Daily window in a Fedora 35 KDE Plasma installation with Plasma 5.23.5 on Wayland. I started Thunderbird 98.0a1 (2022-02-07) and used it. I closed Thunderbird.

Actual results:

After I closed Thunderbird 98.0a1 (2022-02-07), I tried to start it again within 30 seconds. An error box had the message "Thunderbird is already running, but is not responding. To use Thunderbird, you must first close the existing Thunderbird process, restart your device, or use a different profile." The Thunderbird Crash Reporter appeared about a minute after closing Thunderbird. The first crash report had the signature [@ js::RunScript ] and was in NS_DebugBreak at hg:hg.mozilla.org/mozilla-unified:xpcom/base/nsDebugImpl.cpp:9212c99a00f195539b334c8cfea48786448969b0:433
The crash reason was [Parent 1986, Main Thread] ###!!! ABORT: file resource://gre/modules/CrashMonitor.jsm:175
https://crash-stats.thunderbird.net/report/bp-eda32b84-a509-4a57-835a-2f77e1220207#tab-details

Thunderbird 98.0a1 (2022-02-07) crashed 8/8 times after closing, 6 of which had the signature [@ PromiseReactionJob ] with what looked to be the same trace and reason as above.
https://crash-stats.thunderbird.net/report/bp-89e36cf0-e3b6-471c-a70f-c8f411220207

I tried to use mozregression to bisect the problem, but it didn't download anything to test.

mozregression --app thunderbird --good 2022-02-06 --bad 2022-02-07
0:01.19 INFO: Got as far as we can go bisecting nightlies...
0:01.19 INFO: Last good revision: a4c122858ebe9bb672b411e093e6342a53a1243a (2022-02-06)
0:01.19 INFO: First bad revision: 1869b10836585e6f7e9b510c1f96f389b6392936 (2022-02-07)
0:01.19 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a4c122858ebe9bb672b411e093e6342a53a1243a&tochange=1869b10836585e6f7e9b510c1f96f389b6392936

0:01.19 INFO: Switching bisection method to taskcluster
0:01.19 INFO: Getting comm-central builds between a4c122858ebe9bb672b411e093e6342a53a1243a and 1869b10836585e6f7e9b510c1f96f389b6392936
0:02.47 INFO: No more integration revisions, bisection finished.
0:02.47 INFO: Last good revision: a4c122858ebe9bb672b411e093e6342a53a1243a
0:02.47 INFO: First bad revision: 1869b10836585e6f7e9b510c1f96f389b6392936
0:02.47 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a4c122858ebe9bb672b411e093e6342a53a1243a&tochange=1869b10836585e6f7e9b510c1f96f389b6392936

Expected results:

Thunderbird would close normally.

Comment 1

[WaltS48 [:walts48]]

Did not see that crash yesterday but did after updating to version 99.0a1 and quitting it.

https://crash-stats.thunderbird.net/report/bp-a9fa837e-45e5-4f6c-a94f-003f11220208

Comment 2

[Magnus Melin [:mkmelin]]

xref bug 1753968, bug 1753876. But the second part of bug 1753392 should have fixed it. (Too many bugs around this area to keep toll atm.)

Comment 3

[Alfred Peters [:infofrommozilla]]

(In reply to Magnus Melin [:mkmelin] from comment #2)

xref bug 1753968, bug 1753876. But the second part of bug 1753392 should have fixed it. (Too many bugs around this area to keep toll atm.)

Yes, Build ID 20220209104710 no longer crashes here.

Comment 4

[Christian Riechers]

TB 98.0b2 crashed 2/3 times after closing with signature [@ PromiseReactionJob].
Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0
https://crash-stats.thunderbird.net/report/bp-f461d106-e92b-484a-88b4-8e30f1220214
https://crash-stats.thunderbird.net/report/bp-3d68edee-6937-4298-b639-1fe7a1220215

Comment 6

[Wayne Mery (:wsmwk)]

began around the same time ... Bug 1753865 - Crash mozilla::net::Http3Stream::ReadSegments when start PC from sleep mode

Comment 7

[Wayne Mery (:wsmwk)]

Nightly users can find the regression range using https://mozilla.github.io/mozregression/

Comment 9

[Richard Leger]

Wayne,

For your information, few crashes I encountered recently in TB 98.0b3 (64-bit) on Windows 10 Pro (x64) mostly upon TB shutdown but not only (TB crash itself when not used or upon sleep/wakeup), likely TB Core issues:

Thunderbird 98.0 Crash Report [@ js::NativeObject::changeProperty ]
bp-df01cabf-fb7b-484d-b4f8-5204a1220310 10/03/2022, 09:53
bp-b9912591-12aa-4b1d-909a-7bf5a1220309 09/03/2022, 10:01
bp-1aa094ec-727b-46ce-835b-413721220308 08/03/2022, 09:51

0 	xul.dll 	NS_DebugBreak 	/builds/worker/checkouts/gecko/xpcom/base/nsDebugImpl.cpp:433
1 	ucrtbase.dll 	_strset 	?:
2 	xul.dll 	truncf 	?:
3 	xul.dll 	truncf 	?:
4 	xul.dll 	js::NativeObject::changeProperty 	/builds/worker/checkouts/gecko/js/src/vm/Shape.cpp:576
5 	xul.dll 	CanEnterBaselineJIT 	/builds/worker/checkouts/gecko/js/src/jit/BaselineJIT.cpp:333 

Thunderbird 98.0 Crash Report [@ js::jit::JitActivation::clearRematerializedFrames ]
bp-8f6dbd3d-c250-460a-a02f-6b3c21220309 09/03/2022, 15:24

0 	xul.dll 	NS_DebugBreak 	/builds/worker/checkouts/gecko/xpcom/base/nsDebugImpl.cpp:433
1 	ucrtbase.dll 	_strset 	?:
2 	xul.dll 	truncf 	?:
3 	xul.dll 	js::jit::JitActivation::clearRematerializedFrames 	/builds/worker/checkouts/gecko/js/src/vm/JitActivation.cpp:96
4 	xul.dll 	js::LiveSavedFrameCache::~LiveSavedFrameCache 	/builds/worker/checkouts/gecko/js/src/vm/Activation.h:352
5 	xul.dll 	js::jit::JitActivation::~JitActivation 	/builds/worker/checkouts/gecko/js/src/vm/JitActivation.cpp:63 

Thunderbird 98.0 Crash Report [@ static XPCWrappedNative::CallMethod ]
bp-8819ff0b-c658-4c2d-a0fb-976721220302 02/03/2022, 22:47
bp-d4f589cc-1596-40f3-bebd-fd2af1220302 02/03/2022, 17:54

0 	xul.dll 	NS_DebugBreak 	hg:hg.mozilla.org/mozilla-unified:xpcom/base/nsDebugImpl.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:433
1 	xul.dll 	nsDebugImpl::Abort 	hg:hg.mozilla.org/mozilla-unified:xpcom/base/nsDebugImpl.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:132
2 	xul.dll 	XPTC__InvokebyIndex 	?:
3 	? 	? 	?:
Ø 4 	xul.dll 	_tailMerge_d3dcompiler_47.dll 	?:
5 	xul.dll 	static XPCWrappedNative::CallMethod 	hg:hg.mozilla.org/mozilla-unified:js/xpconnect/src/XPCWrappedNative.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:1130
6 	xul.dll 	XPC_WN_CallMethod 	hg:hg.mozilla.org/mozilla-unified:js/xpconnect/src/XPCWrappedNativeJSOps.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:923
7 	xul.dll 	js::InternalCallOrConstruct 	hg:hg.mozilla.org/mozilla-unified:js/src/vm/Interpreter.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:512
8 	xul.dll 	Interpret 	hg:hg.mozilla.org/mozilla-unified:js/src/vm/Interpreter.cpp:444af52b3c682c3eb4311e4e9f8bde08abaea179:3309 

Regards,

Comment 10

[Wayne Mery (:wsmwk)]

How is 99 beta? (you'll have to visit help > about or download it)

Comment 11

[Christian Riechers]

No shutdown crash with 99 beta so far.

Comment 12

[Wayne Mery (:wsmwk)]

Magnus, can you check backtrace to see if crash rate has dropped?

Comment 13

[Magnus Melin [:mkmelin]]

Not seeing this there (but may not be using it right).

Comment 14

[Wayne Mery (:wsmwk)]

Matt, do you still crash?

Comment 15

[Matt Fagnani]

(In reply to Wayne Mery (:wsmwk) from comment #14)

Matt, do you still crash?

No. The last crash of this type when closing Thunderbird Daily was in 99.0a1 (2022-2-8) according to my crash reports.

Comment 16

[Wayne Mery (:wsmwk)]

Thanksf or the update