Closed Bug 1754069 Opened 4 years ago Closed 4 years ago

Convert autoClose configuration to support spotlight and about:welcome

Categories

(Firefox :: Messaging System, task, P1)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Iteration:
99.2 - Feb 21 - Mar 6
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: Mardak, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1754069 - Convert autoClose configuration to support spotlight and about:welcome
48 bytes, text/x-phabricator-request
Details | Review

Instead of duplicating special code in MultiStageAboutWelcome.jsx and MultiStageProtonScreen.jsx to navigate to about:home when advancing from the last screen, we should be able to handle it from one place and call some function where each surface implements the "close" behavior:

  • about:welcome loads about:home
  • spotlight closes modal

This also makes it so we can auto advance from some "middle" screen instead of always closing from the last.

Assignee: nobody → mviar
Iteration: --- → 99.1 - Feb 7 - Feb 20
Priority: -- → P1
Attachment #9263542 - Attachment description: WIP: Bug 1754069 - Convert autoClose configuration to support spotlight and about:welcome → Bug 1754069 - Convert autoClose configuration to support spotlight and about:welcome
Iteration: 99.1 - Feb 7 - Feb 20 → 99.2 - Feb 21 - Mar 6
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/931e154b62d0 Convert autoClose configuration to support spotlight and about:welcome r=Mardak

https://hg.mozilla.org/mozilla-central/rev/931e154b62d0

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Regressions: 1758340
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: