1754105 - Fix non-unified-build bustage in layout/xul and mark directory as safe-to-build in non-unified mode

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

I'm filing this bug on removing REQUIRES_UNIFIED_BUILD from layout/xul/moz.build and fixing all subsequent bustage when building with

ac_add_options --disable-unified-build

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1754105: Fix non-unified build errors in layout/xul, and mark it as safe to build in non-unified mode. r?#layout-reviewers

Build errors being fixed here:

layout/xul/nsDeckFrame.cpp:164:43: error: unknown type name 'nsSetAttrRunnable'

layout/xul/nsMenuBarListener.cpp:45:7: error: cannot initialize a member subobject of type 'mozilla::dom::EventTarget *' with an rvalue of type 'nsINode::Document *' (aka 'mozilla::dom::Document *')
(...where "Document" is not defined; this patch includes the header that defines it, which fixes this.)

dist/include/nsIRollupListener.h:36:38: error: no type named 'LayoutDeviceIntPoint' in namespace 'mozilla'
(For this error, this patch is changing a header outside of layout/xul, but
it's still required in order for layout/xul to build properly, since it's
#included by layout/xul/nsXULPopupManager.cpp (indirectly, via its .h file).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c43ced1d19d9
Fix non-unified build errors in layout/xul, and mark it as safe to build in non-unified mode. r=emilio

Comment 3

[Iulian Moraru]

Backed out for causing bp-hybrid bustages on nsBoxFrame.

Push with failures

Failure log

Backout link

[task 2022-02-08T05:36:34.435Z] 05:36:34     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/layout/xul'
[task 2022-02-08T05:36:34.439Z] 05:36:34     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o nsBoxFrame.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/workspace/obj-build/layout/xul -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/painting -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -pthread -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/harfbuzz -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pixman-1 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/freetype2 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing  -MD -MP -MF .deps/nsBoxFrame.o.pp   /builds/worker/checkouts/gecko/layout/xul/nsBoxFrame.cpp
[task 2022-02-08T05:36:34.439Z] 05:36:34    ERROR -  /builds/worker/checkouts/gecko/layout/xul/nsBoxFrame.cpp:270:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
[task 2022-02-08T05:36:34.440Z] 05:36:34     INFO -    return false;
[task 2022-02-08T05:36:34.440Z] 05:36:34     INFO -           ^~~~~
[task 2022-02-08T05:36:34.440Z] 05:36:34    ERROR -  /builds/worker/checkouts/gecko/layout/xul/nsBoxFrame.cpp:311:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
[task 2022-02-08T05:36:34.440Z] 05:36:34     INFO -    return false;
[task 2022-02-08T05:36:34.441Z] 05:36:34     INFO -           ^~~~~
[task 2022-02-08T05:36:34.441Z] 05:36:34     INFO -  2 errors generated.
[task 2022-02-08T05:36:34.441Z] 05:36:34    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:659: nsBoxFrame.o] Error 1
[task 2022-02-08T05:36:34.441Z] 05:36:34     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/layout/xul'
[task 2022-02-08T05:36:34.442Z] 05:36:34     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-02-08T05:36:34.442Z] 05:36:34     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/media/highway'

Comment 4

[Daniel Holbert [:dholbert]]

Sorry / thanks for the backout; I forgot to build with warnings-as-errors when testing this locally.

I'll fix the error, test on bp-hybrid to make sure there's nothing else I missed, and re-push.

Comment 5

[Daniel Holbert [:dholbert]]

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=dadf0752bcb6d0db08675033cedbcd2c7f0a2d3c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ef7d4b7bbf3
Fix non-unified build errors in layout/xul, and mark it as safe to build in non-unified mode. r=emilio

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9ef7d4b7bbf3