1754126 - Perma browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Uncaught exception in test - Theme is active - threw exception: TypeError: can't access property "isActive", theme is null

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=367015082&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dAwQ3tgQQRCP-M64vpu9_Q/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-02-08T00:08:27.783Z] 00:08:27     INFO - TEST-START | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js
[task 2022-02-08T00:08:28.439Z] 00:08:28     INFO - TEST-INFO | started process screencapture
[task 2022-02-08T00:08:28.554Z] 00:08:28     INFO - TEST-INFO | screencapture: exit 0
[task 2022-02-08T00:08:28.555Z] 00:08:28     INFO - Buffered messages logged at 00:08:27
[task 2022-02-08T00:08:28.555Z] 00:08:28     INFO - Entering test bound open_close_dialog
[task 2022-02-08T00:08:28.555Z] 00:08:28     INFO - TEST-PASS | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Upgrade dialog opened and closed - true == true - 
[task 2022-02-08T00:08:28.556Z] 00:08:28     INFO - Leaving test bound open_close_dialog
[task 2022-02-08T00:08:28.556Z] 00:08:28     INFO - Entering test bound double_click
[task 2022-02-08T00:08:28.557Z] 00:08:28     INFO - TEST-PASS | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Incorrectly handling clicks would have triggered exception - true == true - 
[task 2022-02-08T00:08:28.557Z] 00:08:28     INFO - Leaving test bound double_click
[task 2022-02-08T00:08:28.558Z] 00:08:28     INFO - Entering test bound theme_change
[task 2022-02-08T00:08:28.558Z] 00:08:28     INFO - Buffered messages finished
[task 2022-02-08T00:08:28.559Z] 00:08:28     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Uncaught exception in test - Theme is active - threw exception: TypeError: can't access property "isActive", theme is null
[task 2022-02-08T00:08:28.559Z] 00:08:28     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-08T00:08:28.560Z] 00:08:28     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | A promise chain failed to handle a rejection: can't access property "enable" of null - stack: enableTheme@chrome://browser/content/upgradeDialog.js:93:23
[task 2022-02-08T00:08:28.560Z] 00:08:28     INFO - Rejection date: Tue Feb 08 2022 00:08:28 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 271
[task 2022-02-08T00:08:28.560Z] 00:08:28     INFO - Stack trace:
[task 2022-02-08T00:08:28.560Z] 00:08:28     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:271
[task 2022-02-08T00:08:28.560Z] 00:08:28     INFO - chrome://mochikit/content/browser-test.js:handleTask:1017
[task 2022-02-08T00:08:28.561Z] 00:08:28     INFO - Leaving test bound theme_change
[task 2022-02-08T00:08:28.561Z] 00:08:28     INFO - Entering test bound keyboard_focus_okay
[task 2022-02-08T00:08:28.561Z] 00:08:28     INFO - GECKO(3851) | JavaScript error: chrome://browser/content/upgradeDialog.js, line 93: TypeError: can't access property "enable" of null
[task 2022-02-08T00:08:28.562Z] 00:08:28     INFO - Console message: [JavaScript Error: "TypeError: can't access property "enable" of null" {file: "chrome://browser/content/upgradeDialog.js" line: 93}]
[task 2022-02-08T00:08:28.957Z] 00:08:28     INFO - GECKO(3851) | JavaScript error: chrome://browser/content/upgradeDialog.js, line 93: TypeError: can't access property "enable" of null
[task 2022-02-08T00:08:28.958Z] 00:08:28     INFO - Console message: [JavaScript Error: "TypeError: can't access property "enable" of null" {file: "chrome://browser/content/upgradeDialog.js" line: 93}]
[task 2022-02-08T00:08:56.060Z] 00:08:56     INFO - GECKO(3851) | 2022-02-08 00:08:56.059 firefox[3851:72967] Persistent UI failed to open file file:///Users/cltbld/Library/Saved%20Application%20State/org.mozilla.nightly.savedState/window_1.data: No such file or directory (2)
[task 2022-02-08T00:09:12.976Z] 00:09:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-08T00:09:12.977Z] 00:09:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Test timed out - 
[task 2022-02-08T00:09:12.977Z] 00:09:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-08T00:09:12.978Z] 00:09:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | Uncaught exception received from previously timed out test - subdialog-loaded observer not removed before the end of test
[task 2022-02-08T00:09:12.978Z] 00:09:12     INFO - Entering test bound keep_home
[task 2022-02-08T00:09:12.979Z] 00:09:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-08T00:09:12.979Z] 00:09:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | A promise chain failed to handle a rejection: can't access property "enable" of null - stack: enableTheme@chrome://browser/content/upgradeDialog.js:93:23
[task 2022-02-08T00:09:12.980Z] 00:09:12     INFO - Rejection date: Tue Feb 08 2022 00:08:28 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 271
[task 2022-02-08T00:09:12.980Z] 00:09:12     INFO - Stack trace:
[task 2022-02-08T00:09:12.980Z] 00:09:12     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:271
[task 2022-02-08T00:09:12.980Z] 00:09:12     INFO - chrome://mochikit/content/browser-test.js:nextTest:625
[task 2022-02-08T00:09:12.980Z] 00:09:12     INFO - GECKO(3851) | MEMORY STAT | vsize 7883MB | residentFast 293MB | heapAllocated 119MB
[task 2022-02-08T00:09:12.981Z] 00:09:12     INFO - TEST-OK | browser/components/tests/browser/browser_browserGlue_upgradeDialog.js | took 45198ms
[task 2022-02-08T00:09:12.990Z] 00:09:12     INFO - GECKO(3851) | JavaScript error: chrome://browser/content/tabbrowser-tabs.js, line 1131: TypeError: can't access property "closing", selectedTab is null
[task 2022-02-08T00:09:12.991Z] 00:09:12     INFO - Console message: [JavaScript Error: "TypeError: can't access property "closing", selectedTab is null" {file: "chrome://browser/content/tabbrowser-tabs.js" line: 1131}]
[task 2022-02-08T00:15:23.046Z] 00:15:23     INFO - Buffered messages finished

Comment 1

[Iulian Moraru]

This started to appear on this merge on m-c after that, the same failure started to appear on autoland.
Something strange is happening because when I added the job on the previous merge(the job was green and this test pass), the job failed with the same failure line. https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&resultStatus=retry%2Cpending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-macosx1015-64-shippable-qr%2Fopt-mochitest-browser-chrome-fis-e10s%2Cbc5&selectedTaskRun=O2CVSVeRRFmdhE8ejTKNLQ.0

Comment 2

[Iulian Moraru]

Hi Dave! Can you please take a look at this? Maybe you could find the problem or what triggered this behaviour.

Comment 3

[Ed Lee :Mardak]

The test uses a theme that expired on a specific date (February 8th)

https://searchfox.org/mozilla-central/rev/2a0b0ababd4541ecffb74cbe0820a9d0a25da636/browser/components/tests/browser/browser_browserGlue_upgradeDialog.js#32
https://searchfox.org/mozilla-central/rev/2a0b0ababd4541ecffb74cbe0820a9d0a25da636/browser/themes/BuiltInThemeConfig.jsm#215

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4450b54eea9f
temporary disable browser_browserGlue_upgradeDialog.js on all platforms CLOSED TREE DONTBUILD

Comment 5

[Andreea Pavel [:apavel]]

Test got temporary disabled on all platforms to reduce noise in trees.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4450b54eea9f

Comment 7

[Ed Lee :Mardak]

Attachment: Bug 1754126 - Skip colorway theme test if it has already expired r=pdahiya

Silently ignore themes that are expired and can't be enabled.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/113b63526eb2
Skip colorway theme test if it has already expired r=pdahiya

Comment 9

[Intermittent Failures Robot]

89 failures in 742 pushes (0.12 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 40
• mozilla-central: 6
• try: 27
• mozilla-beta: 16

Platform and build breakdown:

• windows10-32-2004-qr: 2
  • debug: 2
• windows10-64-2004-qr: 10
  • debug: 7
  • opt: 3
• windows10-64-2004-asan-qr: 10
  • opt: 10
• macosx1015-64-qr: 10
  • opt: 5
  • debug: 5
• linux1804-64-qr: 8
  • opt: 5
  • debug: 3
• windows7-32-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 13
  • opt: 13
• windows7-32-shippable-qr: 4
  • opt: 4
• macosx1015-64-shippable-qr: 12
  • opt: 12
• macosx1100-64-shippable-qr: 6
  • opt: 6
• linux1804-64-asan-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 4
  • opt: 4
• windows10-64-2004-devedition-qr: 3
  • opt: 3
• macosx1015-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754126&startday=2022-02-08&endday=2022-02-08&tree=all

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/113b63526eb2

Comment 11

[Intermittent Failures Robot]

23 failures in 715 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 23

Platform and build breakdown:

• windows10-64-2004-asan-qr: 2
  • opt: 2
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 3
  • opt: 3
• linux1804-64-devedition-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 4
  • opt: 4
• windows10-64-2004-devedition-qr: 2
  • opt: 2
• macosx1015-64-devedition-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 3
  • opt: 3
• windows7-32-shippable-qr: 2
  • opt: 2
• macosx1100-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754126&startday=2022-02-09&endday=2022-02-09&tree=all

Comment 12

[Cosmin Sabou [:CosminS]]

(In reply to Atila Butkovits from comment #10)

https://hg.mozilla.org/mozilla-central/rev/113b63526eb2

Looks like this might need to be uplifted to beta too, failures.

Comment 13

[Ed Lee :Mardak]

Comment on attachment 9262873 [details]
Bug 1754126 - Skip colorway theme test if it has already expired r=pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Basically none. Except for users who force the upgrade spotlight to show (it's off by default as the UI is outdated showing expired themes), trying to select the expired theme would not result in an browser console error message.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Skips error messages for feature that's off by default. Patch in phabricator rebased onto mozilla-beta with different browser/components/tests/browser/browser.ini (from mozilla-central)
• String changes made/needed: None

Comment 14

[Intermittent Failures Robot]

41 failures in 697 pushes (0.059 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 34
• mozilla-release: 7

Platform and build breakdown:

• linux1804-64-asan-qr: 4
  • opt: 4
• windows10-64-2004-asan-qr: 3
  • opt: 3
• windows10-64-2004-shippable-qr: 6
  • opt: 6
• linux1804-64-shippable-qr: 8
  • opt: 8
• macosx1015-64-devedition-qr: 4
  • opt: 4
• windows10-64-2004-devedition-qr: 3
  • opt: 3
• windows7-32-shippable-qr: 5
  • opt: 5
• macosx1015-64-shippable-qr: 4
  • opt: 4
• macosx1100-64-shippable-qr: 3
  • opt: 3
• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754126&startday=2022-02-10&endday=2022-02-10&tree=all

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9262873 [details]
Bug 1754126 - Skip colorway theme test if it has already expired r=pdahiya

Approved for 98 beta 4, thanks.

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ab8bfb06513

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9262873 [details]
Bug 1754126 - Skip colorway theme test if it has already expired r=pdahiya

We need this on Release too.

Comment 18

[Intermittent Failures Robot]

169 failures in 3711 pushes (0.046 failures/push) were associated with this bug in the last 7 days.

This is the #4 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 20
• autoland: 40
• try: 29
• mozilla-beta: 73
• mozilla-release: 7

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 1
  • opt: 1
• windows7-32-shippable-qr: 12
  • opt: 12
• macosx1015-64-shippable-qr: 32
  • opt: 32
• windows10-32-2004-qr: 2
  • debug: 2
• windows10-64-2004-qr: 12
  • debug: 9
  • opt: 3
• windows10-64-2004-asan-qr: 15
  • opt: 15
• macosx1015-64-qr: 10
  • opt: 5
  • debug: 5
• linux1804-64-qr: 8
  • opt: 5
  • debug: 3
• windows7-32-qr: 2
  • opt: 2
• linux1804-64-asan-qr: 9
  • opt: 9
• linux1804-64-shippable-qr: 15
  • opt: 15
• windows10-64-2004-shippable-qr: 22
  • opt: 22
• macosx1100-64-shippable-qr: 10
  • opt: 10
• windows10-64-2004-devedition-qr: 8
  • opt: 8
• macosx1015-64-devedition-qr: 8
  • opt: 8
• linux1804-64-devedition-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754126&startday=2022-02-07&endday=2022-02-13&tree=all

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/77a6edf3c8a0