1754132 - Sometimes "WebDriver:Navigate" with a PageLoadStrategy of "none" returns before navigation has started

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When the page load strategy is set to none the navigation commands have to return once a navigation has been started. But with our current implementation this can even happen before. The reason for such a behavior shows the following code:

https://searchfox.org/mozilla-central/rev/4615b544a0f7166233c409c619b426c4025467a7/remote/marionette/navigate.js#219-223

Similar to the situation when we don't expect a load event, we return immediately when a page load strategy of none is selected. But this is wrong because there will be a navigation and we could return too early - before the navigation has actually started. This can lead to race conditions for code running after this method call like the scenario as described on bug 1739540 comment 26.

As such we should wait at least for an unload event before returning from WebDriver:Navigate.

Comment 1

[Alexandra Borovova [:Sasha]]

Discussed with Henrik that actually the event which we should wait for is pagehide

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1754132 - Use WebProgressListener to detect navigation start when PageLoadStrategy is "none".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d03b4ae877e4
Use WebProgressListener to detect navigation start when PageLoadStrategy is "none". r=webdriver-reviewers,whimboo,jdescottes

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d03b4ae877e4