1754172 - Hide "Clear cookies and site data..." in private browsing mode windows

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P3)

Description

[Emma Zühlcke [:emz]]

The "Clear cookies and site data..." button in the identity panel always clears normal browsing data, even if used in a PBM window. This seems unintuitive. We should hide the button in PBM windows and in permanent PBM.

Comment 1

[Harold Camacho]

Attachment: Bug 1754172 - Hide 'Clear cookies and site data...' in private browsing mode windows. r?hsohaney

Comment 2

[Harold Camacho]

Attachment: Bug 1754172 - Hide 'Clear cookies and site data...' in private browsing mode windows. r?hsohaney

Comment 3

[Harold Camacho]

Hi Harshit, I have updated the browser-siteIdentity.js file, and now the "Clear cookies and site data..." button is no longer shown in the identity panel in PBM windows as suggested above.

Comment 4

[Harold Camacho]

Hi Harshit,

I've updated the patch with your suggested changes and added the test as recommended.

Thanks again!

Comment 5

[Harshit Sohaney [:hsohaney]]

Hey Emma, before I accept the patch, I wanted to double check that this was still the behaviour we want (since this was filed 3 years ago).

Comment 6

[Emma Zühlcke [:emz]]

Sounds good! You can also add me as an additional reviewer next time.
Thanks for getting this fixed!

Comment 7

[Emma Zühlcke [:emz]]

Thanks for working on this bug. I see that the patch is r+, can we land it?

Comment 8

[Harold Camacho]

Hi Emma,

Yes please, could you land this for me? I understand the Mercurial → Git migration has already taken place, and my current Mercurial setup is now outdated. Would you mind rebasing this patch on main on my behalf? Really appreciate your help!

Comment 9

[Emma Zühlcke [:emz]]

I've just triggered the land. Let's see if it works with a pre-git patch. 🤞🏻

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d205a646ebee
Hide 'Clear cookies and site data...' in private browsing mode windows. r=hsohaney

Comment 11

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d205a646ebee