1754263 - Eliminate preprocessor %includes from toolkit menu stylesheets

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Sam Foster [:sfoster] (he/him)]

Replace the %includes with either @import or by inlining the included stylesheet. See bug 1659584 for details. This bug should cover:

• toolkit/themes/{platform}/global/menu.css
  • toolkit/themes/shared/menu-scrolling.inc.css

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1754263 - Remove %includes from menu.css stylesheets. r?dao!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef3284274d47
Remove %includes from menu.css stylesheets. r=dao

Comment 3

[Atila Butkovits]

Backed out for cauisng failures at browser_parsable_css.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8d7b06928b4422c83096e7a3412448bd7974b7a2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Z2tIAAA3SjWP5K3wF5Nkog.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ef3284274d479804170f53309890703b3f5ac217

Failure log: https://treeherder.mozilla.org/logviewer?job_id=369901350&repo=autoland&lineNumber=4154

Comment 4

[Sam Foster [:sfoster] (he/him)]

Ah yeah, there's one more %ifdef in the windows stylesheet, so that needed to be marked for preprocessing in the manifest. I'll update and attempt to re-land after the merge.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/839606339f65
Remove %includes from menu.css stylesheets. r=dao

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/839606339f65