1754277 - Fix non-unified-build bustage in layout/svg and mark directory as safe-to-build in non-unified mode

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Daniel Holbert [:dholbert]]

I'm filing this bug on removing REQUIRES_UNIFIED_BUILD from layout/svg/moz.build and fixing all subsequent bustage when building with

ac_add_options --disable-unified-build

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1754277: Fix non-unified build errors in layout/svg, and mark it as safe to build in non-unified mode. r?#layout-reviewers

Below are the build errors fixed here.

• layout/svg/SVGFEUnstyledLeafFrame.cpp:75:33: error: no type named 'SVGFEUnstyledElement' in namespace 'mozilla::dom'

Fixed this by including SVGFilters.h (which defines this type).

• layout/svg/SVGFEContainerFrame.cpp:83:12: error: unknown type name 'SVGFE'; did you mean 'dom::SVGFE'?
• layout/svg/SVGFELeafFrame.cpp:80:12: error: unknown type name 'SVGFE'; did you mean 'dom::SVGFE'?

Fixed these with a 'using' statement for the namespace.

• layout/svg/SVGGFrame.cpp:34:32: error: unknown type name 'SVGElement'

Fixed by including this type's header.

• layout/svg/FilterInstance.cpp:873:9: error: use of undeclared identifier 'nsLayoutUtils'
• layout/svg/SVGOuterSVGFrame.cpp:623:29: error: incomplete type 'nsLayoutUtils' named in nested name specifier

Fixed these by including this header.

Comment 2

[Daniel Holbert [:dholbert]]

https://treeherder.mozilla.org/jobs?repo=try&revision=de1e0a66f2e8cfa16a78ad766afa3cbfe84b8814

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a368d080f3c9
Fix non-unified build errors in layout/svg, and mark it as safe to build in non-unified mode. r=emilio

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a368d080f3c9