Closed
Bug 1754357
Opened 2 years ago
Closed 2 years ago
Stop adding profiler labels from LoaderObserver::On{Begin,End}Load, replace with markers
Categories
(Core :: Gecko Profiler, task, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
Thanks to bug 1745281, base markers are now visible during profiling sessions, so they can be used in LoaderObserver, instead of labels that may compromise the profiling stack (see bug 1749978).
|
Assignee | |
Comment 1•2 years ago
|
||
This observer could be called as unexpected times, making these labels dangerous, leaving the profiling stack in a compromised state.
Instead, we can now use Base Profiler markers, which will also appear during the whole time the Gecko Profiler is running.
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3649922a0ce5 Don't use labels around DllLoads anymore - r=canaltinova
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•