[FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()

RESOLVED FIXED in mozilla1.2final

Status

()

Core
XPCOM
P1
critical
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla1.2final
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Well, I finally got my "convert lots of people to nsCOMArray" build running and
ran into this cool threadsafety assertion on nsCOMArrayEnumerator.  Looks like
the problem is that this never calls NS_INIT_ISUPPORTS() in the constructor...

Good thing that we use mAutoRefCnt now, eh?
Created attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).
reviews?  I'd like to get this fixed before 1.2, for obvious reasons....
Priority: -- → P1
Summary: nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS() → [FIX]nsCOMArrayEnumerator and nsSimpleArrayEnumerator need to NS_INIT_ISUPPORTS()
Target Milestone: --- → mozilla1.2final
isn't there a bug to get rid of NS_INIT_ISUPPORTS? yeah, bug 174225...
If that's landing for 1.2, good.  If not, we need this patch.

Comment 5

16 years ago
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

editor bet against it landing for 1.2. The person who fixes that bug can easily
remove any new instances of NS_INIT_ISUPPORTS().
Attachment #103437 - Flags: review+
> editor bet against it landing for 1.2

er?  what do you mean?
Clarification:  Comment 5 is a response to comments 3 and 4 and has nothing to
do with the real issue here.  ;) 

Comment 8

16 years ago
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

oops. heh.
sr=alecf
Comment on attachment 103437 [details] [diff] [review]
patch (fixes some warnings too).

a=dbaron for trunk checkin
Attachment #103437 - Flags: superreview+
Attachment #103437 - Flags: approval+
fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.