1754429 - Make urlbar and searchbar "where to open" behavior consistent

Status: ASSIGNED

(Firefox :: Address Bar, enhancement, P3)

Description

[Shane Hughes [:aminomancer]]

The urlbar, searchbar, and one-offs use different methods to determine where a result should be opened (which is based on user preferences and keyboard modifiers). Consolidating them into one helper function (or at least making them identical) will remove some inconsistent behavior in edge cases and simplify proposed changes discussed in bug 1753863 and bug 1753878.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1754429 - Consolidate urlbar and search "where" behavior. r=mak,adw

The urlbar, searchbar, and search one-offs currently have different
approaches to determining where a result should be opened based on
prefs and keyboard modifiers. This patch consolidates the behaviors
into a single helper function and resolves a subtle bug that resulted
from the old "where to open" behavior, wherein Ctrl+clicking a one-off
search button would open a new blank tab only to enter search mode.
This should pave the way for bug 1754432 and bug 1754427, as we can
implement the proposed pref(s) in the new helper function and apply the
same consistent behavior to hold the urlbar/search results views open.
This also adds basic testing for the whereToOpenResult method in both
urlbar and searchbar. The tests will need to be adjusted/expanded when
the relevant prefs are changed, but for now this should protect against
regressions directly caused by this patch.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.