Closed Bug 1754857 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32805 - [GridFragmentation] Propagate break-before/break-after from container.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32805 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32805
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[GridFragmentation] Propagate break-before/break-after from container.

...when unfragmented). This patch captures the break-before/break-after
values for grid row(s) when unfragmented. We pass in a break-between
vector into |PlaceItems| which will then use this to set the
break-before/break-after on the fragment.

A followup patch will set this correctly when fragmented.

Bug: 614667
Change-Id: Ie529efe0e5bfe53262d10d874149ffc5c6e67100
Reviewed-on: https://chromium-review.googlesource.com/3453286
WPT-Export-Revision: 2b7ff9475f50219ca0420e440537748f4a447b93

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

PASS: 2
FAIL: 3

Chrome

FAIL: 5

Safari

FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/grid/grid-container-fragmentation-010.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/grid/grid-container-fragmentation-011.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/grid/grid-item-fragmentation-048.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8707b85f53b [wpt PR 32805] - [GridFragmentation] Propagate break-before/break-after from container., a=testonly https://hg.mozilla.org/integration/autoland/rev/807fc6cbce93 [wpt PR 32805] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f8707b85f53b
https://hg.mozilla.org/mozilla-central/rev/807fc6cbce93

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.