1754858 - Move Screen orientation into widget::Screen rather than keeping it around in hal.

Status: RESOLVED FIXED

(Core :: Widget, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

It's where it logically belongs.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1754858 - Simplify screen orientation API implementation. r=gsvelto!,smaug!,m_kato!

Make the ScreenOrientation part of the screen struct, as it should. Stop
using HAL to propagate just screen orientation updates, use the more
general screen manager.

Instead of HAL observers, add a simple observer service notification,
and clean a bunch of the code.

This will simplify bug 1754802 a bit, and is generally simpler.
Shouldn't change behavior. I've tested the events and some common
orientation locking use cases like Youtube, and they behave the same.

Depends on D138461

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66f2b55fec3b
Simplify screen orientation API implementation. r=smaug,m_kato,geckoview-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddbd482689fc
Only avoid orientation unlock call on destructor, to fix OrientationDelegateTest.orientationUnlock.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/66f2b55fec3b
https://hg.mozilla.org/mozilla-central/rev/ddbd482689fc