1754874 - remove fields from supersearch fields based on crash annotations that aren't sent anymore

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In November 2021, I added a crash_report_keys field which contains a list of all the crash annotations from the crash report.

The Socorro processor indexes crash reports pulling some of the field data from the raw_crash which corresponds to the original crash annotations.

Before I go migrate fields from the raw_crash to the processed_crash, it makes sense to remove fields from super_search_fields.py that come from the raw_crash where we haven't seen the annotation in the last couple of months.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do now. This will make bug #1753521 easier.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I went through the 82 keys that are mentioned in super_search_fields.py and these are the ones that haven't shown up since we added the crash_report_keys field:

• ActiveExperiment
• ActiveExperimentBranch
• Bug_1541161
• RecordReplay
• RecordReplayError
• AsyncPluginShutdown
• AsyncPluginShutdownStates
• B2G_OS_Version
• CoGetInterfaceAndReleaseStreamFailure
• IPCExtraSystemError
• Min_ARM_Version

I'll remove those.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6006: bug 1754874: remove unused raw_crash fields from supersearch

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6006: "bug 1754874: remove unused raw_crash fields from supersearch" in dc70dda.

Note that this only covers unused fields in the "raw_crash" namespace for supersearch. It doesn't cover unused fields in the "processed_crash" namespace. I figure we can do that in another bug because we can't do it the same way. I'm not entirely sure how to do it. Maybe we can use "exists" or something.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I wrote a better script for figuring out which annotations are being used. Here are some more:

• AsyncPluginInit shows up in 19 Firefox crash reports all of which look like local builds of old versions
• Theme shows up in 272 Firefox crash reports which look like local builds of old versions
• E10SCohort is in 244 Firefox crash reports all of which are old
• AddonsShouldHaveBlockedE10s is in 232 Firefox crash reports all are old

Here are some others I looked at that we should keep:

• CoMarshalInterfaceFailure shows up in a few, but they're recent versions, so we should keep it
• IsGarbageCollecting shows up in only a few, but they're recent versions, so we should keep it

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6007: bug 1754874: remove more annotations from supersearch

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6007: "bug 1754874: remove more annotations from supersearch" in f91a47e.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this just now in bug #1756845. Marking as FIXED.

Comment 9

[Gabriele Svelto [:gsvelto]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #5)

Here are some others I looked at that we should keep:

• CoMarshalInterfaceFailure shows up in a few, but they're recent versions, so we should keep it
• IsGarbageCollecting shows up in only a few, but they're recent versions, so we should keep it

FYI I went over the current list of crash annotations and both these ones are present, but all the other ones you've removed are not so they're gone for good. Thanks for taking the time to do this!

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

Thank you for double-checking this! I should have asked you to review it before I landed things.