1754940 - Content process alternate winstation should depend on non-native theming

Status: VERIFIED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Bob Owen (:bobowen)]

[Tracking Requested - why for this release]:

Bug 1151941 changed to use an alternate windows station as well as an alternate desktop.
However this depends on non-native theming, so we will make the alternate winstation depend on that.

However we are working on enabling win32k lockdown (a much more important security measure) in the content process and this also depends on non-native theming.
So, we will soon make that override the non-native theming pref.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1754940: Make alternate winstation depend on non-native theme. r=handyman!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9152dd083f41
Make alternate winstation depend on non-native theme. r=handyman

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9152dd083f41

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 9263461 [details]
Bug 1754940: Make alternate winstation depend on non-native theme. r=handyman!

Beta/Release Uplift Approval Request

• User impact if declined: Users who have flipped the non-native theme pref, will have badly rendered controls.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Go to a page with form controls, especially radio buttons and check boxes, for example: https://www.w3schools.com/html/html_forms.asp
  Flip the pref widget.non-native-theme.enabled to false and reload the page.
  Radio buttons render incorrectly. They are probably too small although the effect may vary depending on your monitor and OS theme set up.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change that effectively reverts regressing change when pref is false.
• String changes made/needed: None

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9263461 [details]
Bug 1754940: Make alternate winstation depend on non-native theme. r=handyman!

Fix for a 98 regression, uplift approved for 98 beta 5, thanks.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6fb0fd2c8b9c

Comment 7

[Peter Magyari (Desktop QA)]

I've verified the fix on Firefox Nightly 99.0a1 (20220214092817)

Comment 8

[Peter Magyari (Desktop QA)]

I've also verified the fix on Firefox Beta 98.0b5 (20220215194438)