1754992 - Perma /streams/readable-streams/global.html | Stream objects created in expected globals - assert_equals: reader was created in other global (new) expected false but got true when Gecko 98 merges to Beta on 2022-03-08

Status: VERIFIED FIXED

(Core :: DOM: Streams, defect)

Description

[Cristina Cozmuta (:CrissCozmuta)]

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:

[task 2022-02-11T13:07:19.104Z] 13:07:19     INFO - TEST-START | /streams/readable-streams/global.html
[task 2022-02-11T13:07:19.104Z] 13:07:19     INFO - Clearing pref javascript.options.streams
[task 2022-02-11T13:07:19.108Z] 13:07:19     INFO - Clearing pref dom.streams.readable_stream_default_controller.enabled
[task 2022-02-11T13:07:19.115Z] 13:07:19     INFO - Clearing pref dom.streams.readable_stream_default_reader.enabled
[task 2022-02-11T13:07:19.124Z] 13:07:19     INFO - Clearing pref dom.streams.byte_streams.enabled
[task 2022-02-11T13:07:19.133Z] 13:07:19     INFO - Clearing pref dom.streams.writable_streams.enabled
[task 2022-02-11T13:07:19.149Z] 13:07:19     INFO - Setting pref javascript.options.streams (true)
[task 2022-02-11T13:07:19.164Z] 13:07:19     INFO - Setting pref dom.streams.readable_stream_default_controller.enabled (true)
[task 2022-02-11T13:07:19.179Z] 13:07:19     INFO - Setting pref dom.streams.readable_stream_default_reader.enabled (true)
[task 2022-02-11T13:07:19.194Z] 13:07:19     INFO - Setting pref dom.streams.byte_streams.enabled (true)
[task 2022-02-11T13:07:19.209Z] 13:07:19     INFO - Setting pref dom.streams.writable_streams.enabled (true)
[task 2022-02-11T13:07:19.221Z] 13:07:19     INFO - Closing window 9467ae00-459c-451b-983b-00c41c89a741
[task 2022-02-11T13:07:19.434Z] 13:07:19     INFO - PID 641 | ###!!! [Parent][PCompositorManagerParent] Error: RunMessage(msgname=PCompositorBridge::Msg___delete__) Channel closing: too late to send/recv, messages will be lost
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 | -----------------------------------------------------
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 | Suppressions used:
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 |   count      bytes template
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 |      12        384 nsComponentManagerImpl
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 |       2        288 libfontconfig.so
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 | -----------------------------------------------------
[task 2022-02-11T13:07:19.443Z] 13:07:19     INFO - PID 641 | ###!!! [Parent][PImageBridgeParent] Error: RunMessage(msgname=PImageBridge::Msg_WillClose) Channel closing: too late to send/recv, messages will be lost
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - 
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - TEST-UNEXPECTED-FAIL | /streams/readable-streams/global.html | Stream objects created in expected globals - assert_equals: reader was created in other global (new) expected false but got true
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - @http://web-platform.test:8000/streams/readable-streams/global.html:46:18
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2534:25
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:677:36
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:676:20
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - ........
[task 2022-02-11T13:07:20.135Z] 13:07:20     INFO - TEST-OK | /streams/readable-streams/global.html | took 1049ms
[task 2022-02-11T13:07:20.138Z] 13:07:20     INFO - PID 641 | 1644584840137	Marionette	INFO	Stopped listening on port 39507
<...>
[task 2022-02-11T13:07:28.064Z] 13:07:28     INFO - Browser exited with return code 0
[task 2022-02-11T13:07:28.066Z] 13:07:28     INFO - Closing logging queue
[task 2022-02-11T13:07:28.066Z] 13:07:28     INFO - queue closed
[task 2022-02-11T13:07:28.091Z] 13:07:28     INFO - INFO | runtests.py | ASan using symbolizer at /builds/worker/workspace/build/application/firefox/llvm-symbolizer
[task 2022-02-11T13:07:28.102Z] 13:07:28     INFO - LSan enabled.
[task 2022-02-11T13:07:28.103Z] 13:07:28     INFO - INFO | runtests.py | ASan running in default memory configuration
[task 2022-02-11T13:07:28.103Z] 13:07:28     INFO - UBSan enabled.
[task 2022-02-11T13:07:28.104Z] 13:07:28     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmp9dk3_iq3
[task 2022-02-11T13:07:28.133Z] 13:07:28     INFO - PID 1117 | 1644584800884	Marionette	INFO	Marionette enabled
[task 2022-02-11T13:07:28.136Z] 13:07:28     INFO - PID 1117 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at /tmp/tmpmqjhs7i4/search.json.mozlz4", (void 0)))
[task 2022-02-11T13:07:28.137Z] 13:07:28     INFO - PID 1117 | 1644584813388	Marionette	INFO	Listening on port 41234
[task 2022-02-11T13:07:28.139Z] 13:07:28     INFO - Starting runner
[task 2022-02-11T13:07:29.044Z] 13:07:29     INFO - TEST-START | /streams/readable-streams/patched-global.any.serviceworker.html

Hi Matthew,
Can you please take a look at these fails ?
fail 1
fail 2
It seems they were caused by this push
Thank you!

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

So I've done some investigation. So far I am baffled.

1. I can reproduce; I pulled the revision from try for this job 6fedc14a017d1de3a784111a2f07139e790f79eb and sure enough, that WPT test fails.
2. I confirm that building central from the same mozconfig passes that WPT. Similarly, building with the parent revision of 6fedc14a017 also passes.
3. I confirm that both builds are using DOM streams (in xpcshell I tested by running new ReadableStream({type: null}); JS Streams issued a RangeError for this, whereas DOM streams issues a TypeError)

Number 2 implies that something in 6fedc14a017 causes the failure. On the hypothesis is that it's EARLY_BETA_OR_EARLIER changing I built with 6fedc14a017 but with that single change reverted; it still fails. Which at this point is the end of my investigation path:

The failing test is one I wrote, and I'm deeply aware that there's possibly a misunderstanding of the globals involved here. I strongly would prefer removing/disabling the test to backing out the regressing bug.

Olli: Does your experience suggest anything to investigate here?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

I don't think this requires immediate backout, no need to rush.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #1)

On the hypothesis is that it's EARLY_BETA_OR_EARLIER changing I built with 6fedc14a017

The task also fails for early beta.

Comment 4

[Tom S [:evilpie]]

Actually I think this is caused by dom.webidl.crosscontext_hasinstance.enabled being false on Nightly, but true everywhere else.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Ah yes, please add that flag to WPT meta. 🤦

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1754992 - Explicitly set cross-context hasinstance pref for ReadableStreams global test r?saschanaz

Comment 7

[Norisz Fay [:noriszfay]]

The patch seems to be working as of today's early central as beta simulation

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1a9efe4b0e
Explicitly set cross-context hasinstance pref for ReadableStreams global test r=saschanaz,evilpie

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6e1a9efe4b0e