Closed Bug 1755100 Opened 5 months ago Closed 5 months ago

Change the best match toggle in the preferences UI to a checkbox

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
99 Branch
Tracking Status
firefox99 --- verified

People

(Reporter: adw, Assigned: daisuke)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Product revised the requirements for the best match preferences UI. The toggle switch should be a checkbox under the "Search engines" checkbox. We may also add a learn-more link or description to it -- this isn't finalized yet but hopefully will be early next week. The Figma spec has been updated to show the checkbox.

Bug 1753738 hasn't landed yet, but we should go ahead and land it since it's been reviewed and some of my patches depend on it. This bug can build on top of that one.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Blocks: 1755828
Attachment #9263689 - Attachment description: Bug 1755100: Change the best match toggle in the preferences UI to a checkbox. → WIP: Bug 1755100: Change the best match toggle in the preferences UI to a checkbox.
Attachment #9263689 - Attachment description: WIP: Bug 1755100: Change the best match toggle in the preferences UI to a checkbox. → Bug 1755100: Change the best match toggle in the preferences UI to a checkbox.
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d86fb206ed4f
Change the best match toggle in the preferences UI to a checkbox. r=adw,preferences-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch

STR for QA:

  1. Enable Firefox Suggest
  2. Enable the new best match feature by setting browser.urlbar.bestMatch.enabled to true
  3. Open about:preferences#privacy, scroll down to the Address Bar section, and verify that a "Top pick" checkbox appears as the last checkbox. It should be checked by default
  4. Uncheck the checkbox and verify that browser.urlbar.suggest.bestmatch is set to false
  5. Check the checkbox and verify that browser.urlbar.suggest.bestmatch is set to true (this pref will remain bold in about:config because it's sticky)
  6. Set browser.urlbar.bestMatch.enabled to false and verify the checkbox no longer appears
  7. Set browser.urlbar.bestMatch.enabled to true again and verify the checkbox appears again
Flags: qe-verify+
Flags: in-testsuite+

We have verified this issue on the latest Nightly 99.0a1 build (Build ID: 20220218090822) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

  • In order to verify this issue we have used the STR described in comment 4.

While we have verified this issue, we have encountered a new one. The "Top Pick" option is available in "about:preferences#privacy" page on non-US regions even if Best Match is disabled.
We have logged this behavior in Bug 1756162.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.